Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix: Remove redundant VMID parameters #5672

Merged
merged 2 commits into from
Dec 19, 2022
Merged

Bugfix: Remove redundant VMID parameters #5672

merged 2 commits into from
Dec 19, 2022

Conversation

castorsky
Copy link
Contributor

SUMMARY

Removed redundant VMID parameter from URI builder from all functions in proxmox_disk and proxmox_nic modules.

It fixes possible issues similar to #5492.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

proxmox_disk
proxmox_nic

ADDITIONAL INFORMATION

Conversation about this fix was here.

Modified functions have been tested with:

  • Controller: openSUSE Tumbleweed (python 3.10)
  • Target: Proxmox 7.3-3
  • Ansible:
    • core 2.14.1
    • community-general 6.1.0
  • Proxmoxer: 2.0.0
  • Requests: 2.28.1

@ansibullbot
Copy link
Collaborator

cc @Ajpantuso @Kogelvis @Thulium-Drake @joshainglis @karmab @tleguern
click here for bot help

@ansibullbot ansibullbot added bug This issue/PR relates to a bug cloud module module needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR plugins plugin (any type) labels Dec 9, 2022
@felixfontein felixfontein added check-before-release PR will be looked at again shortly before release and merged if possible. backport-5 labels Dec 9, 2022
felixfontein
felixfontein approved these changes Dec 9, 2022
View reviewed changes
Copy link
Collaborator

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good to me, I'll merge in ~one week if nobody objects.

@ansibullbot ansibullbot removed the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR label Dec 9, 2022
@ansibullbot ansibullbot added the stale_ci CI is older than 7 days, rerun before merging label Dec 17, 2022
@felixfontein felixfontein merged commit fab73a1 into ansible-collections:main Dec 19, 2022
@patchback
Copy link

patchback bot commented Dec 19, 2022 •
edited
Loading

Backport to stable-5: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-5/fab73a1d1e168fc04a5723d45bb3251149d9d856/pr-5672

Backported as #5708

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@felixfontein felixfontein removed the check-before-release PR will be looked at again shortly before release and merged if possible. label Dec 19, 2022
patchback bot pushed a commit that referenced this pull request Dec 19, 2022
@castorsky @patchback
Bugfix: Remove redundant VMID parameters (#5672)
8699218 
* Remove redundant parameters VMID

* Add changelog fragment

(cherry picked from commit fab73a1)
@patchback patchback bot mentioned this pull request Dec 19, 2022
Merged
@patchback
Copy link

patchback bot commented Dec 19, 2022 •
edited
Loading

Backport to stable-6: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-6/fab73a1d1e168fc04a5723d45bb3251149d9d856/pr-5672

Backported as #5709

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@felixfontein
Copy link
Collaborator

@castorsky thanks for this fix!

patchback bot pushed a commit that referenced this pull request Dec 19, 2022
@castorsky @patchback
Bugfix: Remove redundant VMID parameters (#5672)
785004c 
* Remove redundant parameters VMID

* Add changelog fragment

(cherry picked from commit fab73a1)
@patchback patchback bot mentioned this pull request Dec 19, 2022
Merged
@github-actions
Copy link

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

felixfontein pushed a commit that referenced this pull request Dec 19, 2022
@patchback @castorsky
[PR #5672/fab73a1d backport][stable-6] Bugfix: Remove redundant VMID …
02e6a86 
…parameters (#5709)

Bugfix: Remove redundant VMID parameters (#5672)

* Remove redundant parameters VMID

* Add changelog fragment

(cherry picked from commit fab73a1)

Co-authored-by: castorsky <csky57@gmail.com>
felixfontein pushed a commit that referenced this pull request Dec 19, 2022
@patchback @castorsky
[PR #5672/fab73a1d backport][stable-5] Bugfix: Remove redundant VMID …
40d094e 
…parameters (#5708)

Bugfix: Remove redundant VMID parameters (#5672)

* Remove redundant parameters VMID

* Add changelog fragment

(cherry picked from commit fab73a1)

Co-authored-by: castorsky <csky57@gmail.com>
@castorsky castorsky deleted the redundant_parameters branch January 9, 2023 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixfontein felixfontein felixfontein approved these changes

Assignees
No one assigned
Labels
bug This issue/PR relates to a bug cloud module module plugins plugin (any type) stale_ci CI is older than 7 days, rerun before merging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@castorsky @ansibullbot @felixfontein