Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pacman: fix upgrade: yes #4275

Merged
merged 4 commits into from
Feb 23, 2022
Merged

pacman: fix upgrade: yes #4275

merged 4 commits into from
Feb 23, 2022

Conversation

jraby
Copy link
Contributor

@jraby jraby commented Feb 23, 2022

Fixes #4274

Sorry about that, I tested the upgrade in check mode only apparently... (and even the test were wrong 🤦 )

@felixfontein
Copy link
Collaborator

Thanks for the quick fix! Can you please add a changelog fragment? Thanks.

@felixfontein felixfontein added backport-4 check-before-release PR will be looked at again shortly before release and merged if possible. labels Feb 23, 2022
@ansibullbot
Copy link
Collaborator

cc @indrajitr @tchernomax
click here for bot help

@ansibullbot ansibullbot added module module os packaging plugins plugin (any type) tests tests unit tests/unit labels Feb 23, 2022
@ansibullbot

This comment was marked as outdated.

Sign in to view
@ansibullbot ansibullbot added ci_verified Push fixes to PR branch to re-run CI needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels Feb 23, 2022
@ansibullbot ansibullbot removed ci_verified Push fixes to PR branch to re-run CI needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels Feb 23, 2022
@felixfontein felixfontein removed the check-before-release PR will be looked at again shortly before release and merged if possible. label Feb 23, 2022
@felixfontein felixfontein merged commit b9f62bb into ansible-collections:main Feb 23, 2022
@patchback
Copy link

patchback bot commented Feb 23, 2022 •
edited
Loading

Backport to stable-4: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-4/b9f62bb4ef7808c0220d154c10c1c846f7c3361e/pr-4275

Backported as #4277

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@felixfontein
Copy link
Collaborator

@jraby thanks for fixing this!

patchback bot pushed a commit that referenced this pull request Feb 23, 2022
@jraby @patchback
pacman: fix upgrade: yes (#4275)
84f5883 
* s/sys-upgrade/sysupgrade/

* changelog fragment

* yamllint

* more fragment tweaks

(cherry picked from commit b9f62bb)
@patchback patchback bot mentioned this pull request Feb 23, 2022
Merged
felixfontein pushed a commit that referenced this pull request Feb 23, 2022
@patchback @jraby
pacman: fix upgrade: yes (#4275) (#4277)
8e9a348 
* s/sys-upgrade/sysupgrade/

* changelog fragment

* yamllint

* more fragment tweaks

(cherry picked from commit b9f62bb)

Co-authored-by: Jean Raby <jean@raby.sh>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixfontein felixfontein felixfontein approved these changes

Assignees
No one assigned
Labels
module module os packaging plugins plugin (any type) tests tests unit tests/unit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pacman --sync --sysupgrade broken
3 participants
@jraby @felixfontein @ansibullbot