pacman: fix upgrade: yes (#4275) (#4277)

* s/sys-upgrade/sysupgrade/ * changelog fragment * yamllint * more fragment tweaks (cherry picked from commit b9f62bb) Co-authored-by: Jean Raby <jean@raby.sh>
ansible-collections · Feb 23, 2022 · 8e9a348 · 8e9a348
1 parent 2622513
commit 8e9a348
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 3 deletions.
diff --git a/changelogs/fragments/4275-pacman-sysupgrade.yml b/changelogs/fragments/4275-pacman-sysupgrade.yml
@@ -0,0 +1,3 @@
+bugfixes:
+  - pacman - fix ``upgrade=yes``
+    (https://github.com/ansible-collections/community.general/pull/4275, https://github.com/ansible-collections/community.general/issues/4274).
diff --git a/plugins/modules/packaging/os/pacman.py b/plugins/modules/packaging/os/pacman.py
@@ -410,7 +410,7 @@ def upgrade(self):
             cmd = [
                 self.pacman_path,
                 "--sync",
-                "--sys-upgrade",
+                "--sysupgrade",
                 "--quiet",
                 "--noconfirm",
             ]

diff --git a/tests/unit/plugins/modules/packaging/os/test_pacman.py b/tests/unit/plugins/modules/packaging/os/test_pacman.py
@@ -365,7 +365,7 @@ def test_update_db(self, mock_empty_inventory, module_args, expected_call):
                 # for real
                 False,
                 {
-                    "args": ["pacman", "--sync", "--sys-upgrade", "--quiet", "--noconfirm"],
+                    "args": ["pacman", "--sync", "--sysupgrade", "--quiet", "--noconfirm"],
                     "return_value": [0, "stdout", "stderr"],
                 },
                 None,
@@ -377,7 +377,7 @@ def test_update_db(self, mock_empty_inventory, module_args, expected_call):
                     "args": [
                         "pacman",
                         "--sync",
-                        "--sys-upgrade",
+                        "--sysupgrade",
                         "--quiet",
                         "--noconfirm",
                         "--some",