openssh_keypair: Populate return values when keypair exists and check_mode=true #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1,2 @@ | |||
| minor_changes: | |||
| - openssh_keypair - enhanced ``check_mode`` to populate return values for existing keypairs (https://github.com/ansible-collections/community.crypto/pull/230). | |||
There was a problem hiding this comment.
Suggested change
| - openssh_keypair - enhanced ``check_mode`` to populate return values for existing keypairs (https://github.com/ansible-collections/community.crypto/pull/230). | |
| - openssh_keypair - fix ``check_mode`` to populate return values for existing keypairs (https://github.com/ansible-collections/community.crypto/issues/113, https://github.com/ansible-collections/community.crypto/pull/230). |
|
@Ajpantuso btw, if you have time to review something, #203, #204, #205 and #206 are looking for reviews ;) |
Ah, so the tables have turned :). Will take a look before my next contribution here since I saw at least one of these blocking another request. |
felixfontein
approved these changes
May 12, 2021
|
@Ajpantuso thanks for fixing/implementing this! :) |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Enhancing
check_modeforopenssh_keypairwith populated return values if keypair already exists.Fixes #113
ISSUE TYPE
COMPONENT NAME
plugins/modules/openssh_keypair.py
ADDITIONAL INFORMATION
Straight forward change to execute the check logic prior to dumping the return values into the
resultsdictionary whencheck_mode=true.