openssl_csr_info: move main code to module_utils to allow easier implementation of diff mode #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 20, 2021
Merged
Closed
Closed
This was referenced May 10, 2021
Ajpantuso
requested changes
May 13, 2021
| result['extensions_by_oid'] = self._get_all_extensions() | ||
|
|
||
| result['signature_valid'] = self._is_signature_valid() | ||
| if self.validate_signature and not result['signature_valid']: |
There was a problem hiding this comment.
This is for a new feature to be made available to users in a future PR?
There was a problem hiding this comment.
Yes, it's part of #150 (https://github.com/ansible-collections/community.crypto/pull/150/files#diff-16695b5a53f8b40bd252c59ca4278fc4096b92f07ae1f96edb890c508704bf76R192). The whole four PRs are part of that PR, I moved some of the commits to individual PRs to increase the chance that someone actually reviews them :)
There was a problem hiding this comment.
Cool, just checking that it was not pushed early or partially implemented.
Co-authored-by: Ajpantuso <ajpantuso@gmail.com>
|
@Ajpantuso thanks a lot for reviewing this one as well! :) |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Subset of #150.
ISSUE TYPE
COMPONENT NAME
openssl_csr_info