Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ec2_vpc_route_table - Test idempotency with adding a route #496

Merged
merged 2 commits into from
Mar 25, 2021

Conversation

tremble
Copy link
Contributor

@tremble tremble commented Mar 24, 2021

SUMMARY

Get a test in place for #359

ISSUE TYPE
  • Test Pull Request
COMPONENT NAME

ec2_vpc_route_table

ADDITIONAL INFORMATION

@ansibullbot
Copy link

@tremble tremble force-pushed the ec2_vpc_route_table/tests branch from 78b00f6 to 6c2e6ce Compare March 24, 2021 13:43
@tremble tremble requested review from alinabuzachis and goneri March 24, 2021 13:55
@tremble tremble merged commit 9623b6c into ansible-collections:main Mar 25, 2021
@tremble tremble deleted the ec2_vpc_route_table/tests branch June 29, 2021 12:56
alinabuzachis pushed a commit to alinabuzachis/community.aws that referenced this pull request Jul 19, 2021
…ollections#496)

* Test idempotency with adding a route
* tweak changelog to include bugfix link
alinabuzachis pushed a commit to alinabuzachis/community.aws that referenced this pull request Jul 19, 2021
…ollections#496)

* Test idempotency with adding a route
* tweak changelog to include bugfix link
danielcotton pushed a commit to danielcotton/community.aws that referenced this pull request Nov 23, 2021
…ollections#496)

* Test idempotency with adding a route
* tweak changelog to include bugfix link
alinabuzachis pushed a commit to alinabuzachis/community.aws that referenced this pull request May 25, 2022
…ollections#496)

* Test idempotency with adding a route
* tweak changelog to include bugfix link

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections@9623b6c
alinabuzachis pushed a commit to alinabuzachis/community.aws that referenced this pull request May 25, 2022
…ght botocore available for tests needing recent botocore (ansible-collections#496)

rework s3_bucket and ec2_instance tests to make sure they have the right botocore available for tests needing recent botocore

SUMMARY
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
s3_bucket
ec2_instance
ADDITIONAL INFORMATION

Reviewed-by: Alina Buzachis <None>
Reviewed-by: None <None>
alinabuzachis pushed a commit to alinabuzachis/community.aws that referenced this pull request May 25, 2022
…nsible-collections#404)

Add constraints.txt and requirements.txt for unit/integration tests

SUMMARY
Now that we state that we support specific minimum versions of the AWS SDKs, make sure we base our unit/integration tests against them such that modules need to explicitly test/request newer versions of the SDKs.
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
tests/integration
tests/unit
ADDITIONAL INFORMATION
Once merged into amazon.aws we should merge this into community.aws
Depends-On: ansible-collections#453
Depends-On: ansible-collections#454
Depends-On: ansible-collections#450
Depends-On: ansible-collections#496
See also: ansible/ansible-zuul-jobs#991

Reviewed-by: Jill R <None>
Reviewed-by: None <None>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants