ec2_vpc_route_table: Don't fail if a route was already created.

[stefanhorning]

SUMMARY

Fixes #357

ISSUE TYPE

• Bugfix Pull Request

COMPONENT NAME

ec2_vpc_route_table

ADDITIONAL INFORMATION

Catches error if route already exists. Not sure if all params get compared though for that exception to happen.

[ansibullbot]

cc @jillr @s-hertel @tremble @willthames @wimnat
click here for bot help

[stefanhorning]

Build fails with a request limit issue:

ClientError: An error occurred (RequestLimitExceeded) when calling the DescribeInternetGateways operation (reached max retries: 4): Request limit exceeded.

Wonder if my change did anything in this regard, or if we have to fix existing tests to pause between AWS requests (i.e. module executions)

[alinabuzachis]

Hi @stefanhorning, thank you for your contribution. May you kindly add a changelog https://docs.ansible.com/ansible/latest/community/development_process.html#changelogs and rebase? In addition, it would also be good if you could add a functional test to make sure the change is working correctly. If you need any help please feel free to reach us on IRC #ansible-aws.

[tremble]

Hi @stefanhorning,

sorry for the delay in looking into this PR. The PR looks sensible enough.

To reduce the risk of someone accidentally introducing a regression, if possible please could you rebase and update the test suite to include an example of testing this specific case. I tried reproducing the issue and wasn't able to, so I'm not sure what the procedure to trigger the issue is:

  - name: CHECK MODE - add route to public route table
    ec2_vpc_route_table:
      vpc_id: "{{ vpc.vpc.id }}"
      tags:
        Public: "true"
        Name: "Public route table"
      routes:
      - dest: 0.0.0.0/0
        gateway_id: igw
    check_mode: True
    register: check_mode_results

  - name: assert a route would be added
    assert:
      that:
        - check_mode_results.changed

  - name: add a route to public route table
    ec2_vpc_route_table:
      vpc_id: "{{ vpc.vpc.id }}"
      tags:
        Public: "true"
        Name: "Public route table"
      routes:
      - dest: 0.0.0.0/0
        gateway_id: igw
    register: add_routes

  - name: assert route table contains new route
    assert:
      that:
        - add_routes.changed
        - add_routes.route_table.routes|length == 2

  - name: CHECK MODE - re-add route to public route table
    ec2_vpc_route_table:
      vpc_id: "{{ vpc.vpc.id }}"
      tags:
        Public: "true"
        Name: "Public route table"
      routes:
      - dest: 0.0.0.0/0
        gateway_id: igw 
    check_mode: True
    register: check_mode_results

  - name: assert a route would not be added
    assert:
      that:
        - check_mode_results is not changed

  - name: re-add a route to public route table
    ec2_vpc_route_table:
      vpc_id: "{{ vpc.vpc.id }}"
      tags:
        Public: "true"
        Name: "Public route table"
      routes:
      - dest: 0.0.0.0/0
        gateway_id: igw
    register: add_routes

  - name: assert route table contains route
    assert:
      that:
        - add_routes is not changed
        - add_routes.route_table.routes|length == 2

[jillr]

Agreed - change looks good but a test would be helpful.
We'll be migrating this module to amazon.aws in early April so it would be good to get this merged before then if possible.

[stefanhorning]

Rebased now. Will look into tests later.

[tremble]

I have a vague memory of seeing the 'RouteAlreadyExists' in the integration tests before and that is seemed to be caused by the describe call misbehaving (which has been fixed by switching to a paginated lookup). In the interest of getting this fix in I'm going to get this merged and add a basic test in #496.