Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PR #2229/f2bd35b1 backport][stable-9] aws_ssm - refactor _prepare_terminal() method #2246

Merged
merged 1 commit into from
Feb 13, 2025
Merged

[PR #2229/f2bd35b1 backport][stable-9] aws_ssm - refactor _prepare_terminal() method #2246

merged 1 commit into from
Feb 13, 2025

Conversation

patchback[bot]
Copy link

@patchback patchback bot commented Feb 13, 2025

This is a backport of PR #2229 as merged into main (f2bd35b).

SUMMARY

Refer to https://issues.redhat.com/browse/ACA-2094
Refactor _prepare_terminal() and add unit tests

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

connection/aws_ssm

@abikouo @patchback
aws_ssm - refactor _prepare_terminal() method (#2229)
b29b83c 
SUMMARY

Refer to https://issues.redhat.com/browse/ACA-2094
Refactor _prepare_terminal() and add unit tests

ISSUE TYPE

Feature Pull Request

COMPONENT NAME

connection/aws_ssm

Reviewed-by: Helen Bailey <hebailey@redhat.com>
Reviewed-by: Alina Buzachis
(cherry picked from commit f2bd35b)
@patchback patchback bot mentioned this pull request Feb 13, 2025
Merged
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/e8ed0c129301476287999c237d133403

❌ ansible-galaxy-importer FAILURE in 5m 47s (non-voting)
✔️ build-ansible-collection SUCCESS in 10m 28s
✔️ ansible-test-splitter SUCCESS in 4m 00s
✔️ integration-community.aws-1 SUCCESS in 23m 14s
✔️ integration-community.aws-2 SUCCESS in 15m 39s
✔️ integration-community.aws-3 SUCCESS in 13m 59s
✔️ integration-community.aws-4 SUCCESS in 15m 36s
✔️ integration-community.aws-5 SUCCESS in 14m 51s
✔️ integration-community.aws-6 SUCCESS in 13m 26s
✔️ integration-community.aws-7 SUCCESS in 16m 10s
✔️ integration-community.aws-8 SUCCESS in 14m 32s
✔️ integration-community.aws-9 SUCCESS in 14m 18s
✔️ integration-community.aws-10 SUCCESS in 6m 33s
✔️ integration-community.aws-11 SUCCESS in 13m 24s
Skipped 11 jobs

@abikouo abikouo added the mergeit Merge the PR (SoftwareFactory) label Feb 13, 2025
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/0725a815e8ec40279660a25aad127b8a

❌ ansible-galaxy-importer FAILURE in 4m 12s (non-voting)
✔️ build-ansible-collection SUCCESS in 10m 44s
✔️ ansible-test-splitter SUCCESS in 4m 26s
✔️ integration-community.aws-1 SUCCESS in 22m 56s
✔️ integration-community.aws-2 SUCCESS in 14m 04s
✔️ integration-community.aws-3 SUCCESS in 15m 47s
✔️ integration-community.aws-4 SUCCESS in 16m 16s
✔️ integration-community.aws-5 SUCCESS in 15m 21s
✔️ integration-community.aws-6 SUCCESS in 13m 06s
✔️ integration-community.aws-7 SUCCESS in 15m 42s
✔️ integration-community.aws-8 SUCCESS in 15m 09s
✔️ integration-community.aws-9 SUCCESS in 15m 16s
✔️ integration-community.aws-10 SUCCESS in 5m 05s
✔️ integration-community.aws-11 SUCCESS in 16m 24s
Skipped 11 jobs

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 03475dd into stable-9 Feb 13, 2025
82 of 83 checks passed
@softwarefactory-project-zuul softwarefactory-project-zuul bot deleted the patchback/backports/stable-9/f2bd35b1e5d9c333ae7f1d63f52ad97b6ad12466/pr-2229 branch February 13, 2025 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abikouo abikouo abikouo approved these changes

Assignees
No one assigned
Labels
mergeit Merge the PR (SoftwareFactory)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@abikouo