Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aws_ssm - refactor _prepare_terminal() method #2229

Merged
merged 2 commits into from
Feb 13, 2025
Merged

aws_ssm - refactor _prepare_terminal() method #2229

merged 2 commits into from
Feb 13, 2025

Conversation

abikouo
Copy link
Contributor

@abikouo abikouo commented Feb 4, 2025

SUMMARY

Refer to https://issues.redhat.com/browse/ACA-2094
Refactor _prepare_terminal() and add unit tests

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

connection/aws_ssm

@abikouo abikouo force-pushed the ssm_prepare_terminal_refactor branch from b714c0e to cb1fc61 Compare February 4, 2025 09:38
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/76f606a55dfe4b4e9cc201ffe43414da

✔️ ansible-galaxy-importer SUCCESS in 3m 25s (non-voting)
✔️ build-ansible-collection SUCCESS in 10m 44s
✔️ ansible-test-splitter SUCCESS in 4m 03s
✔️ integration-community.aws-1 SUCCESS in 22m 42s
✔️ integration-community.aws-2 SUCCESS in 14m 03s
✔️ integration-community.aws-3 SUCCESS in 14m 04s
✔️ integration-community.aws-4 SUCCESS in 14m 06s
✔️ integration-community.aws-5 SUCCESS in 13m 59s
✔️ integration-community.aws-6 SUCCESS in 13m 29s
✔️ integration-community.aws-7 SUCCESS in 15m 29s
✔️ integration-community.aws-8 SUCCESS in 13m 14s
✔️ integration-community.aws-9 SUCCESS in 15m 11s
✔️ integration-community.aws-10 SUCCESS in 4m 10s
✔️ integration-community.aws-11 SUCCESS in 15m 33s
Skipped 11 jobs

@abikouo abikouo force-pushed the ssm_prepare_terminal_refactor branch from cb1fc61 to 647dd70 Compare February 12, 2025 14:17
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/86a542c9d3424a88b40621cd749043e0

❌ ansible-galaxy-importer FAILURE in 5m 20s (non-voting)
✔️ build-ansible-collection SUCCESS in 10m 38s
✔️ ansible-test-splitter SUCCESS in 3m 52s
✔️ integration-community.aws-1 SUCCESS in 22m 48s
✔️ integration-community.aws-2 SUCCESS in 14m 40s
✔️ integration-community.aws-3 SUCCESS in 16m 08s
✔️ integration-community.aws-4 SUCCESS in 16m 21s
✔️ integration-community.aws-5 SUCCESS in 15m 26s
✔️ integration-community.aws-6 SUCCESS in 14m 02s
✔️ integration-community.aws-7 SUCCESS in 16m 38s
✔️ integration-community.aws-8 SUCCESS in 16m 15s
✔️ integration-community.aws-9 SUCCESS in 15m 46s
✔️ integration-community.aws-10 SUCCESS in 5m 55s
✔️ integration-community.aws-11 SUCCESS in 16m 10s
Skipped 11 jobs

hakbailey
hakbailey approved these changes Feb 13, 2025
View reviewed changes
Copy link
Contributor

@hakbailey hakbailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See one inline comment regarding type hinting, otherwise this looks good to me.

@abikouo abikouo added mergeit Merge the PR (SoftwareFactory) backport-9 labels Feb 13, 2025
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/d2e76c5566c24a8dbc9c4de0ac79172f

❌ ansible-galaxy-importer FAILURE in 4m 02s (non-voting)
✔️ build-ansible-collection SUCCESS in 10m 13s
✔️ ansible-test-splitter SUCCESS in 3m 54s
✔️ integration-community.aws-1 SUCCESS in 25m 22s
✔️ integration-community.aws-2 SUCCESS in 14m 44s
✔️ integration-community.aws-3 SUCCESS in 15m 53s
✔️ integration-community.aws-4 SUCCESS in 14m 07s
✔️ integration-community.aws-5 SUCCESS in 14m 49s
✔️ integration-community.aws-6 SUCCESS in 16m 42s
✔️ integration-community.aws-7 SUCCESS in 15m 02s
✔️ integration-community.aws-8 SUCCESS in 16m 15s
✔️ integration-community.aws-9 SUCCESS in 14m 49s
✔️ integration-community.aws-10 SUCCESS in 5m 28s
✔️ integration-community.aws-11 SUCCESS in 14m 00s
Skipped 11 jobs

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit f2bd35b into ansible-collections:main Feb 13, 2025
47 of 87 checks passed
@patchback Patchback
Copy link

patchback bot commented Feb 13, 2025 •
edited
Loading

Backport to stable-9: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-9/f2bd35b1e5d9c333ae7f1d63f52ad97b6ad12466/pr-2229

Backported as #2246

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Feb 13, 2025
@abikouo @patchback
aws_ssm - refactor _prepare_terminal() method (#2229)
b29b83c 
SUMMARY

Refer to https://issues.redhat.com/browse/ACA-2094
Refactor _prepare_terminal() and add unit tests

ISSUE TYPE

Feature Pull Request

COMPONENT NAME

connection/aws_ssm

Reviewed-by: Helen Bailey <hebailey@redhat.com>
Reviewed-by: Alina Buzachis
(cherry picked from commit f2bd35b)
@patchback patchback bot mentioned this pull request Feb 13, 2025
Merged
softwarefactory-project-zuul bot pushed a commit that referenced this pull request Feb 13, 2025
@patchback
aws_ssm - refactor _prepare_terminal() method (#2229) (#2246)
03475dd 
This is a backport of PR #2229 as merged into main (f2bd35b).
SUMMARY

Refer to https://issues.redhat.com/browse/ACA-2094
Refactor _prepare_terminal() and add unit tests

ISSUE TYPE


Feature Pull Request

COMPONENT NAME

connection/aws_ssm

Reviewed-by: Bikouo Aubin
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hakbailey hakbailey hakbailey approved these changes

@alinabuzachis alinabuzachis alinabuzachis approved these changes

@tremble tremble Awaiting requested review from tremble

@GomathiselviS GomathiselviS Awaiting requested review from GomathiselviS

Assignees
No one assigned
Labels
backport-9 mergeit Merge the PR (SoftwareFactory)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@abikouo @hakbailey @alinabuzachis