Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PR #2080/044b8d8a backport][stable-9] Fix aws_ssm when Powershell uses CLIXML #2218

Merged
merged 1 commit into from
Jan 27, 2025
Merged

[PR #2080/044b8d8a backport][stable-9] Fix aws_ssm when Powershell uses CLIXML #2218

merged 1 commit into from
Jan 27, 2025

Conversation

patchback[bot]
Copy link

@patchback patchback bot commented Jan 24, 2025

This is a backport of PR #2080 as merged into main (044b8d8).

SUMMARY

This PR adds the code suggested by @PatrickV-code on #1952

In short, connection to Windows based EC2 instances using aws_ssm connection and using the become option of runas fails every job.
The job itself actually finishes, but as Powershell 5 adds additional wrapping with CLIXML information.
Which makes the output unreadable for Ansible.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

aws_ssm

@matpompili @patchback
Fix aws_ssm when Powershell uses CLIXML (#2080)
add34a4 
SUMMARY

This PR adds the code suggested by @PatrickV-code on #1952

In short, connection to Windows based EC2 instances using aws_ssm connection and using the become option of runas fails every job.
The job itself actually finishes, but as Powershell 5 adds additional wrapping with CLIXML information.
Which makes the output unreadable for Ansible.

ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME

aws_ssm

Reviewed-by: Markus Bergholz <git@osuv.de>
Reviewed-by: Alina Buzachis
Reviewed-by: Bikouo Aubin
(cherry picked from commit 044b8d8)
@patchback patchback bot mentioned this pull request Jan 24, 2025
Merged
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/608e150092e1427eaa3757c508950fd2

❌ ansible-galaxy-importer FAILURE in 4m 49s (non-voting)
✔️ build-ansible-collection SUCCESS in 10m 27s
✔️ ansible-test-splitter SUCCESS in 4m 03s
❌ integration-community.aws-1 FAILURE in 13m 28s
❌ integration-community.aws-2 FAILURE in 12m 17s
❌ integration-community.aws-3 FAILURE in 13m 45s
❌ integration-community.aws-4 FAILURE in 14m 23s
❌ integration-community.aws-5 FAILURE in 13m 55s
❌ integration-community.aws-6 FAILURE in 15m 45s
❌ integration-community.aws-7 FAILURE in 14m 19s
❌ integration-community.aws-8 FAILURE in 10m 32s
❌ integration-community.aws-9 FAILURE in 12m 30s
❌ integration-community.aws-10 FAILURE in 12m 33s
✔️ integration-community.aws-11 SUCCESS in 6m 21s
Skipped 11 jobs

@abikouo
Copy link
Contributor

abikouo commented Jan 27, 2025

recheck

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/d282364bf9264a1ab9d8f9ce3eb6f534

❌ ansible-galaxy-importer FAILURE in 5m 00s (non-voting)
✔️ build-ansible-collection SUCCESS in 10m 23s
✔️ ansible-test-splitter SUCCESS in 4m 29s
✔️ integration-community.aws-1 SUCCESS in 24m 24s
✔️ integration-community.aws-2 SUCCESS in 15m 36s
✔️ integration-community.aws-3 SUCCESS in 15m 12s
✔️ integration-community.aws-4 SUCCESS in 15m 10s
✔️ integration-community.aws-5 SUCCESS in 15m 21s
✔️ integration-community.aws-6 SUCCESS in 15m 04s
✔️ integration-community.aws-7 SUCCESS in 15m 24s
✔️ integration-community.aws-8 SUCCESS in 14m 20s
✔️ integration-community.aws-9 SUCCESS in 16m 48s
✔️ integration-community.aws-10 SUCCESS in 6m 09s
✔️ integration-community.aws-11 SUCCESS in 17m 19s
Skipped 11 jobs

@abikouo abikouo added the mergeit Merge the PR (SoftwareFactory) label Jan 27, 2025
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/334115c5146c48f3b2134588c68edd43

✔️ ansible-galaxy-importer SUCCESS in 7m 57s (non-voting)
✔️ build-ansible-collection SUCCESS in 10m 50s
✔️ ansible-test-splitter SUCCESS in 4m 18s
✔️ integration-community.aws-1 SUCCESS in 25m 16s
✔️ integration-community.aws-2 SUCCESS in 14m 16s
✔️ integration-community.aws-3 SUCCESS in 14m 02s
✔️ integration-community.aws-4 SUCCESS in 15m 40s
✔️ integration-community.aws-5 SUCCESS in 15m 14s
✔️ integration-community.aws-6 SUCCESS in 13m 22s
✔️ integration-community.aws-7 SUCCESS in 13m 57s
✔️ integration-community.aws-8 SUCCESS in 13m 35s
✔️ integration-community.aws-9 SUCCESS in 13m 46s
✔️ integration-community.aws-10 SUCCESS in 6m 13s
✔️ integration-community.aws-11 SUCCESS in 14m 16s
Skipped 11 jobs

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit a86b51b into stable-9 Jan 27, 2025
46 of 83 checks passed
@softwarefactory-project-zuul softwarefactory-project-zuul bot deleted the patchback/backports/stable-9/044b8d8a9babd91baa51d2c0a2836175c8e7a9e1/pr-2080 branch January 27, 2025 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
mergeit Merge the PR (SoftwareFactory)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abikouo @matpompili