-
Notifications
You must be signed in to change notification settings - Fork 403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix aws_ssm when Powershell uses CLIXML #2080
Fix aws_ssm when Powershell uses CLIXML #2080
Conversation
Build failed. ❌ ansible-galaxy-importer FAILURE in 5m 07s (non-voting) |
recheck |
Build succeeded. ❌ ansible-galaxy-importer FAILURE in 5m 37s (non-voting) |
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 6m 35s (non-voting) |
@tremble I fixed the issue with black, should be ready to be rechecked. |
Build succeeded. ❌ ansible-galaxy-importer FAILURE in 5m 25s (non-voting) |
Hi @tremble, anything else I can do for this PR? |
regate |
regate |
Build failed (gate pipeline). For information on how to proceed, see https://ansible.softwarefactory-project.io/zuul/buildset/82b72a6197ad42bebffe63736d011238 ✔️ ansible-galaxy-importer SUCCESS in 3m 16s (non-voting) |
regate |
Build failed (gate pipeline). For information on how to proceed, see https://ansible.softwarefactory-project.io/zuul/buildset/8ba12f476c344df280ae7f2fbd8425df ✔️ ansible-galaxy-importer SUCCESS in 3m 18s (non-voting) |
regate |
Build failed (gate pipeline). For information on how to proceed, see https://ansible.softwarefactory-project.io/zuul/buildset/bb093155316a42a5aec0fe8b68204601 ❌ ansible-galaxy-importer FAILURE in 4m 12s (non-voting) |
|
regate |
Build failed (gate pipeline). For information on how to proceed, see https://ansible.softwarefactory-project.io/zuul/buildset/148de36d24f44b7ea38235154ff29725 ❌ ansible-galaxy-importer FAILURE in 4m 52s (non-voting) |
Build failed. ✔️ ansible-galaxy-importer SUCCESS in 3m 20s (non-voting) |
recheck |
Build failed. ✔️ ansible-galaxy-importer SUCCESS in 4m 15s (non-voting) |
Build failed. ✔️ ansible-galaxy-importer SUCCESS in 3m 23s (non-voting) |
Build failed. ❌ ansible-galaxy-importer FAILURE in 4m 22s (non-voting) |
@markuman @alinabuzachis I updated the PR to include the latest changes in I am at a loss here, we really need this change merged, and I don't know what I can do to get that workflow to pass. Suggestions? |
Build failed. ❌ ansible-galaxy-importer FAILURE in 4m 10s (non-voting) |
recheck |
Build failed. ✔️ ansible-galaxy-importer SUCCESS in 3m 10s (non-voting) |
Build failed (gate pipeline). For information on how to proceed, see https://ansible.softwarefactory-project.io/zuul/buildset/1ae28e61246349e8b8bb07a3e41e6c8f ✔️ ansible-galaxy-importer SUCCESS in 3m 28s (non-voting) |
00b3ffe
to
9fa19a0
Compare
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 3m 20s (non-voting) |
Build succeeded (gate pipeline). ❌ ansible-galaxy-importer FAILURE in 4m 57s (non-voting) |
044b8d8
into
ansible-collections:main
Backport to stable-8: 💚 backport PR created✅ Backport PR branch: Backported as #2217 🤖 @patchback |
SUMMARY This PR adds the code suggested by @PatrickV-code on #1952 In short, connection to Windows based EC2 instances using aws_ssm connection and using the become option of runas fails every job. The job itself actually finishes, but as Powershell 5 adds additional wrapping with CLIXML information. Which makes the output unreadable for Ansible. ISSUE TYPE Bugfix Pull Request COMPONENT NAME aws_ssm Reviewed-by: Markus Bergholz <git@osuv.de> Reviewed-by: Alina Buzachis Reviewed-by: Bikouo Aubin (cherry picked from commit 044b8d8)
Backport to stable-9: 💚 backport PR created✅ Backport PR branch: Backported as #2218 🤖 @patchback |
SUMMARY This PR adds the code suggested by @PatrickV-code on #1952 In short, connection to Windows based EC2 instances using aws_ssm connection and using the become option of runas fails every job. The job itself actually finishes, but as Powershell 5 adds additional wrapping with CLIXML information. Which makes the output unreadable for Ansible. ISSUE TYPE Bugfix Pull Request COMPONENT NAME aws_ssm Reviewed-by: Markus Bergholz <git@osuv.de> Reviewed-by: Alina Buzachis Reviewed-by: Bikouo Aubin (cherry picked from commit 044b8d8)
This is a backport of PR #2080 as merged into main (044b8d8). SUMMARY This PR adds the code suggested by @PatrickV-code on #1952 In short, connection to Windows based EC2 instances using aws_ssm connection and using the become option of runas fails every job. The job itself actually finishes, but as Powershell 5 adds additional wrapping with CLIXML information. Which makes the output unreadable for Ansible. ISSUE TYPE Bugfix Pull Request COMPONENT NAME aws_ssm
SUMMARY
This PR adds the code suggested by @PatrickV-code on #1952
ISSUE TYPE
COMPONENT NAME
aws_ssm