Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update contributing to sync with amazon.aws #1714

Merged
merged 1 commit into from
Feb 22, 2023
Merged

Update contributing to sync with amazon.aws #1714

merged 1 commit into from
Feb 22, 2023

Conversation

tremble
Copy link
Contributor

@tremble tremble commented Feb 8, 2023

Fixes: #1607

SUMMARY

Update CONTRIBUTING.md to sync with amazon.aws and pick up various recent improvements
(See also ansible-collections/amazon.aws#924)

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

CONTRIBUTING.md

ADDITIONAL INFORMATION

@tremble tremble marked this pull request as ready for review February 8, 2023 11:21
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

✔️ ansible-galaxy-importer SUCCESS in 4m 03s
✔️ build-ansible-collection SUCCESS in 6m 04s
✔️ ansible-test-sanity-docker-devel SUCCESS in 10m 28s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 9m 44s (non-voting)
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 14m 02s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 10m 36s
✔️ ansible-test-sanity-docker-stable-2.14 SUCCESS in 19m 25s
✔️ ansible-test-units-amazon-aws-python36 SUCCESS in 5m 53s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 5m 45s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 6m 12s
✔️ ansible-test-units-amazon-aws-python310 SUCCESS in 6m 04s

@tremble tremble added the mergeit Merge the PR (SoftwareFactory) label Feb 15, 2023
@softwarefactory-project-zuul
Copy link
Contributor

Build failed (gate pipeline). For information on how to proceed, see
http://docs.openstack.org/infra/manual/developers.html#automated-testing

https://ansible.softwarefactory-project.io/zuul/buildset/4415c348eeca4c9aa24ce567f5f54f3e

✔️ ansible-galaxy-importer SUCCESS in 3m 29s
✔️ build-ansible-collection SUCCESS in 12m 32s
❌ ansible-test-sanity-docker-devel RETRY_LIMIT in 1m 33s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 9m 48s (non-voting)
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 8m 54s
❌ ansible-test-sanity-docker-stable-2.13 RETRY_LIMIT in 1m 30s
✔️ ansible-test-sanity-docker-stable-2.14 SUCCESS in 9m 57s
✔️ ansible-test-units-amazon-aws-python36 SUCCESS in 6m 34s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 5m 23s
❌ ansible-test-units-amazon-aws-python39 RETRY_LIMIT in 16s
✔️ ansible-test-units-amazon-aws-python310 SUCCESS in 5m 46s

@tremble
Copy link
Contributor Author

tremble commented Feb 15, 2023

regate

@softwarefactory-project-zuul
Copy link
Contributor

Build failed (gate pipeline). For information on how to proceed, see
http://docs.openstack.org/infra/manual/developers.html#automated-testing

https://ansible.softwarefactory-project.io/zuul/buildset/672dd03ac0f24217bb4460f324ad24bb

✔️ ansible-galaxy-importer SUCCESS in 5m 14s
✔️ build-ansible-collection SUCCESS in 13m 38s
❌ ansible-test-sanity-docker-devel RETRY_LIMIT in 15s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 13m 39s (non-voting)
❌ ansible-test-sanity-docker-stable-2.12 RETRY_LIMIT in 16s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 13m 04s
❌ ansible-test-sanity-docker-stable-2.14 RETRY_LIMIT in 16s
✔️ ansible-test-units-amazon-aws-python36 SUCCESS in 7m 53s
❌ ansible-test-units-amazon-aws-python38 RETRY_LIMIT in 17s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 7m 29s
❌ ansible-test-units-amazon-aws-python310 RETRY_LIMIT in 16s

@tremble
Copy link
Contributor Author

tremble commented Feb 22, 2023

regate

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/933413377cdc4fabb5c7e0024d0a38e4

✔️ ansible-galaxy-importer SUCCESS in 3m 41s
✔️ build-ansible-collection SUCCESS in 12m 34s
✔️ ansible-test-sanity-docker-devel SUCCESS in 8m 36s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 8m 33s (non-voting)
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 8m 55s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 8m 49s
✔️ ansible-test-sanity-docker-stable-2.14 SUCCESS in 9m 35s
✔️ ansible-test-units-amazon-aws-python36 SUCCESS in 6m 02s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 6m 22s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 5m 32s
✔️ ansible-test-units-amazon-aws-python310 SUCCESS in 5m 41s

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit fc2d0ac into ansible-collections:main Feb 22, 2023
@github-actions
Copy link

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

kamilturek pushed a commit to kamilturek/community.aws that referenced this pull request Mar 19, 2023
@tremble @kamilturek
Update contributing to sync with amazon.aws (ansible-collections#1714)
92befc9 
Update contributing to sync with amazon.aws

Fixes: ansible-collections#1607
SUMMARY
Update CONTRIBUTING.md to sync with amazon.aws and pick up various recent improvements
(See also ansible-collections/amazon.aws#924)
ISSUE TYPE

Docs Pull Request

COMPONENT NAME
CONTRIBUTING.md
ADDITIONAL INFORMATION

Reviewed-by: Alina Buzachis
@tremble tremble deleted the contributions/sync/20230208 branch September 29, 2023 08:28
abikouo pushed a commit to abikouo/community.aws that referenced this pull request Oct 24, 2023
@tremble
Mass update of docs and tests (credentials/session tokens) (ansible-c…
e50e2e0 
…ollections#1714)

Mass update of docs and tests (credentials/session tokens)

SUMMARY
We had a cleanup of credentials/session parameters which included a batch of deprecations and renames.
Ensure that all of our tests and docs are using the 'canonical' names
ISSUE TYPE

Docs Pull Request

COMPONENT NAME
plugins/inventory/aws_ec2.py
plugins/lookup/secretsmanager_secret.py
plugins/lookup/ssm_parameter.py
plugins/modules/ec2_security_group.py
tests/integration/targets
ADDITIONAL INFORMATION
See Also: ansible-collections#1172

Reviewed-by: Alina Buzachis
Reviewed-by: Mark Chappell
abikouo pushed a commit to abikouo/community.aws that referenced this pull request Oct 24, 2023
@tremble
tests drop use of ec2_region (ansible-collections#1721)
910fcb4 
Integration tests - Drop use of ec2_region

SUMMARY
Follow up to ansible-collections#1714
missed "ec2_region"
ISSUE TYPE

Docs Pull Request

COMPONENT NAME
tests/
ADDITIONAL INFORMATION

Reviewed-by: Alina Buzachis
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alinabuzachis alinabuzachis alinabuzachis approved these changes

@markuman markuman Awaiting requested review from markuman

Assignees
No one assigned
Labels
community_review docs mergeit Merge the PR (SoftwareFactory) needs_triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Document how to run integration tests more clearly
3 participants
@tremble @alinabuzachis @ansibullbot