Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document how to run integration tests more clearly #1607

Closed
1 task done
mdavis-xyz opened this issue Nov 29, 2022 · 1 comment · Fixed by #1714
Closed
1 task done

Document how to run integration tests more clearly #1607

mdavis-xyz opened this issue Nov 29, 2022 · 1 comment · Fixed by #1714
Labels
docs needs_triage

Comments

@mdavis-xyz
Copy link
Contributor

Summary

In amazon.aws we just merged this PR for this issue, to add more information to the contributing docs.

This repo has the same state as the other repo had before that PR. I think we should apply the same changes.

We can either:

  • copy-paste the changes into here
  • link to the docs in that other repo from here, and add a few sentences to explain the differences

Which approach is preferable?

Issue Type

Documentation Report

Component Name

CONTRIBUTING.md

Ansible Version

$ ansible --version

Collection Versions

N/A

Configuration

N/A

OS / Environment

No response

Additional Information

No response

Code of Conduct

  • I agree to follow the Ansible Code of Conduct
@ansibullbot
Copy link

Files identified in the description:
None

If these files are inaccurate, please update the component name section of the description or use the !component bot command.

click here for bot help

tremble added a commit to tremble/community.aws that referenced this issue Feb 8, 2023
@tremble
Update contributing to sync with amazon.aws
e975a53 
Fixes: ansible-collections#1607
@tremble tremble mentioned this issue Feb 8, 2023
Merged
softwarefactory-project-zuul bot pushed a commit that referenced this issue Feb 22, 2023
@tremble
Update contributing to sync with amazon.aws (#1714)
fc2d0ac 
Update contributing to sync with amazon.aws

Fixes: #1607
SUMMARY
Update CONTRIBUTING.md to sync with amazon.aws and pick up various recent improvements
(See also ansible-collections/amazon.aws#924)
ISSUE TYPE

Docs Pull Request

COMPONENT NAME
CONTRIBUTING.md
ADDITIONAL INFORMATION

Reviewed-by: Alina Buzachis
kamilturek pushed a commit to kamilturek/community.aws that referenced this issue Mar 19, 2023
@tremble @kamilturek
Update contributing to sync with amazon.aws (ansible-collections#1714)
92befc9 
Update contributing to sync with amazon.aws

Fixes: ansible-collections#1607
SUMMARY
Update CONTRIBUTING.md to sync with amazon.aws and pick up various recent improvements
(See also ansible-collections/amazon.aws#924)
ISSUE TYPE

Docs Pull Request

COMPONENT NAME
CONTRIBUTING.md
ADDITIONAL INFORMATION

Reviewed-by: Alina Buzachis
abikouo pushed a commit to abikouo/community.aws that referenced this issue Oct 24, 2023
@tremble
s3_object - fix NoSuchTagSet error when S3 endpoint doesn't support t…
985d8b1 
…ags (ansible-collections#1813)

s3_object - fix NoSuchTagSet error when S3 endpoint doesn't support tags

SUMMARY
is_boto3_error_code only supports being passed a string or list.  In the refactor of s3_object it was passed a tuple, so the errors weren't being cleanly caught.
ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
s3_object
ADDITIONAL INFORMATION
fixes: ansible-collections#1607

Reviewed-by: Alina Buzachis
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
docs needs_triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update contributing to sync with amazon.aws tremble/community.aws
2 participants
@mdavis-xyz @ansibullbot