Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #1197/877ebbd8 backport][stable-3] ec2_customer_gateway: fix bgp_asn documentation inconsistency #1207

Conversation

patchback[bot]
Copy link

@patchback patchback bot commented Jun 3, 2022

This is a backport of PR #1197 as merged into main (877ebbd).

SUMMARY

Fixes #1075

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

ec2_customer_gateway

ADDITIONAL INFORMATION

While current documentation for the parameter states that
Border Gateway Protocol (BGP) Autonomous System Number (ASN), required when I(state=present).,
according to boto3 documentation, bgp_asn defaults to 65000.

ec2_customer_gateway: fix bgp_asn documentation inconsistency

SUMMARY

Fixes #1075

ISSUE TYPE

Docs Pull Request

COMPONENT NAME

ec2_customer_gateway
ADDITIONAL INFORMATION

While current documentation for the parameter states that
Border Gateway Protocol (BGP) Autonomous System Number (ASN), required when I(state=present).,
according to  boto3 documentation, bgp_asn defaults to 65000.

Reviewed-by: Markus Bergholz <git@osuv.de>
Reviewed-by: Alina Buzachis <None>
(cherry picked from commit 877ebbd)
@ansibullbot
Copy link

@ansibullbot ansibullbot added community_review docs module module needs_triage new_contributor Help guide this first time contributor plugins plugin (any type) small_patch Hopefully easy to review labels Jun 3, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

ansible-galaxy-importer FAILURE in 4m 03s (non-voting)
✔️ build-ansible-collection SUCCESS in 4m 50s
✔️ ansible-test-sanity-docker-devel SUCCESS in 11m 25s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 9m 22s
✔️ ansible-test-sanity-docker-stable-2.9 SUCCESS in 12m 58s
✔️ ansible-test-sanity-docker-stable-2.11 SUCCESS in 10m 31s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 11m 37s
✔️ ansible-test-units-community-aws-python38 SUCCESS in 5m 47s
✔️ ansible-test-units-community-aws-python39 SUCCESS in 6m 25s
✔️ ansible-test-splitter SUCCESS in 2m 25s
✔️ integration-community.aws-1 SUCCESS in 7m 05s
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

@markuman markuman added the mergeit Merge the PR (SoftwareFactory) label Jun 4, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

ansible-galaxy-importer FAILURE in 4m 26s (non-voting)
✔️ build-ansible-collection SUCCESS in 5m 39s
✔️ ansible-test-sanity-docker-devel SUCCESS in 11m 01s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 10m 12s
✔️ ansible-test-sanity-docker-stable-2.9 SUCCESS in 12m 43s
✔️ ansible-test-sanity-docker-stable-2.11 SUCCESS in 11m 32s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 9m 43s
✔️ ansible-test-units-community-aws-python38 SUCCESS in 5m 49s
✔️ ansible-test-units-community-aws-python39 SUCCESS in 6m 09s
✔️ ansible-test-splitter SUCCESS in 2m 46s
✔️ integration-community.aws-1 SUCCESS in 5m 18s
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 58335f7 into stable-3 Jun 4, 2022
@softwarefactory-project-zuul softwarefactory-project-zuul bot deleted the patchback/backports/stable-3/877ebbd871d8d11e35f4ef74d0d9e4ecd2300a74/pr-1197 branch June 4, 2022 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community_review docs mergeit Merge the PR (SoftwareFactory) module module new_contributor Help guide this first time contributor plugins plugin (any type) small_patch Hopefully easy to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants