-
Notifications
You must be signed in to change notification settings - Fork 403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ec2_customer_gateway: bgp_asn is not required #1075
Comments
Files identified in the description:
If these files are inaccurate, please update the |
@neilkatin Thank you for raising this. Would you be willing to open a pull request to fix that inconsistency? |
ec2_customer_gateway: fix bgp_asn documentation inconsistency SUMMARY Fixes #1075 ISSUE TYPE Docs Pull Request COMPONENT NAME ec2_customer_gateway ADDITIONAL INFORMATION While current documentation for the parameter states that Border Gateway Protocol (BGP) Autonomous System Number (ASN), required when I(state=present)., according to boto3 documentation, bgp_asn defaults to 65000. Reviewed-by: Markus Bergholz <git@osuv.de> Reviewed-by: Alina Buzachis <None>
ec2_customer_gateway: fix bgp_asn documentation inconsistency SUMMARY Fixes #1075 ISSUE TYPE Docs Pull Request COMPONENT NAME ec2_customer_gateway ADDITIONAL INFORMATION While current documentation for the parameter states that Border Gateway Protocol (BGP) Autonomous System Number (ASN), required when I(state=present)., according to boto3 documentation, bgp_asn defaults to 65000. Reviewed-by: Markus Bergholz <git@osuv.de> Reviewed-by: Alina Buzachis <None> (cherry picked from commit 877ebbd)
ec2_customer_gateway: fix bgp_asn documentation inconsistency SUMMARY Fixes #1075 ISSUE TYPE Docs Pull Request COMPONENT NAME ec2_customer_gateway ADDITIONAL INFORMATION While current documentation for the parameter states that Border Gateway Protocol (BGP) Autonomous System Number (ASN), required when I(state=present)., according to boto3 documentation, bgp_asn defaults to 65000. Reviewed-by: Markus Bergholz <git@osuv.de> Reviewed-by: Alina Buzachis <None> (cherry picked from commit 877ebbd)
…#1207) [PR #1197/877ebbd8 backport][stable-3] ec2_customer_gateway: fix bgp_asn documentation inconsistency This is a backport of PR #1197 as merged into main (877ebbd). SUMMARY Fixes #1075 ISSUE TYPE Docs Pull Request COMPONENT NAME ec2_customer_gateway ADDITIONAL INFORMATION While current documentation for the parameter states that Border Gateway Protocol (BGP) Autonomous System Number (ASN), required when I(state=present)., according to boto3 documentation, bgp_asn defaults to 65000. Reviewed-by: Markus Bergholz <git@osuv.de>
…#1206) [PR #1197/877ebbd8 backport][stable-2] ec2_customer_gateway: fix bgp_asn documentation inconsistency This is a backport of PR #1197 as merged into main (877ebbd). SUMMARY Fixes #1075 ISSUE TYPE Docs Pull Request COMPONENT NAME ec2_customer_gateway ADDITIONAL INFORMATION While current documentation for the parameter states that Border Gateway Protocol (BGP) Autonomous System Number (ASN), required when I(state=present)., according to boto3 documentation, bgp_asn defaults to 65000. Reviewed-by: Markus Bergholz <git@osuv.de>
Summary
The ec2_customer_gateway module has incorrect documentation for the bgp_asn parameter.
It says the ASN must be passed when state=present, but the code defaults to 25000 if the parameter is absent. See the ensure_cgw_present() method:
Collection Versions
$ ansible-galaxy collection list
Configuration
$ ansible-config dump --only-changed
OS / Environment
main branch, as of 2022-04-18.
Additional Information
Suggested rewording:
Code of Conduct
The text was updated successfully, but these errors were encountered: