Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RDS Subnet Group Module does not manages tagging the resource #552

Closed
emanuele-leopardi opened this issue Apr 21, 2021 · 2 comments · Fixed by #562
Closed

RDS Subnet Group Module does not manages tagging the resource #552

emanuele-leopardi opened this issue Apr 21, 2021 · 2 comments · Fixed by #562
Assignees
Labels
bug This issue/PR relates to a bug module module plugins plugin (any type)

Comments

@emanuele-leopardi
Copy link

SUMMARY

rds_subnet_group module currently doesn't support tagging the subnet group itself

ISSUE TYPE
  • Bug Report

Cannot add tags directly passing them to the module

COMPONENT NAME

rds_subnet_group.py

ANSIBLE VERSION

Not needed

CONFIGURATION

Not needed

OS / ENVIRONMENT

Not needed

STEPS TO REPRODUCE
EXPECTED RESULTS
ACTUAL RESULTS

@ansibullbot
Copy link

Files identified in the description:

If these files are inaccurate, please update the component name section of the description or use the !component bot command.

click here for bot help

@ansibullbot
Copy link

@ansibullbot ansibullbot added bug This issue/PR relates to a bug module module needs_triage plugins plugin (any type) labels Apr 21, 2021
@alinabuzachis alinabuzachis self-assigned this Apr 21, 2021
softwarefactory-project-zuul bot pushed a commit that referenced this issue Mar 29, 2022
rds_subnet_group: Add tags feature and enable check_mode

SUMMARY

rds_subnet_group: Add tags feature and enable check_mode
Fixes: #552

Depends-On: ansible-collections/amazon.aws#553
ISSUE TYPE


Feature Pull Request

COMPONENT NAME

rds_subnet_group

Reviewed-by: Jill R <None>
Reviewed-by: Mark Chappell <None>
Reviewed-by: Alina Buzachis <None>
Reviewed-by: Mark Woolley <mw@marknet15.com>
Reviewed-by: Markus Bergholz <git@osuv.de>
patchback bot pushed a commit that referenced this issue Mar 29, 2022
rds_subnet_group: Add tags feature and enable check_mode

SUMMARY

rds_subnet_group: Add tags feature and enable check_mode
Fixes: #552

Depends-On: ansible-collections/amazon.aws#553
ISSUE TYPE

Feature Pull Request

COMPONENT NAME

rds_subnet_group

Reviewed-by: Jill R <None>
Reviewed-by: Mark Chappell <None>
Reviewed-by: Alina Buzachis <None>
Reviewed-by: Mark Woolley <mw@marknet15.com>
Reviewed-by: Markus Bergholz <git@osuv.de>
(cherry picked from commit ce599bd)
softwarefactory-project-zuul bot pushed a commit that referenced this issue Mar 29, 2022
[PR #562/ce599bdf backport][stable-3] rds_subnet_group: Add tags feature and enable check_mode

This is a backport of PR #562 as merged into main (ce599bd).
SUMMARY

rds_subnet_group: Add tags feature and enable check_mode
Fixes: #552

Depends-On: ansible-collections/amazon.aws#553
ISSUE TYPE


Feature Pull Request

COMPONENT NAME

rds_subnet_group

Reviewed-by: Mark Woolley <mw@marknet15.com>
alinabuzachis pushed a commit to alinabuzachis/community.aws that referenced this issue May 25, 2022
elb_classic_lb - deprecate the ec2_elb fact

SUMMARY
deprecates the ec2_elb fact in favour of the elb return value.
Split off from ansible-collections#377
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
elb_classic_lb
ADDITIONAL INFORMATION
(yes, this module set a fact with the same name, but different content, as the elb_instance module.)

Reviewed-by: Alina Buzachis <None>
Reviewed-by: None <None>
abikouo pushed a commit to abikouo/community.aws that referenced this issue Oct 24, 2023
elb_classic_lb - Remove deprecated ec2_elb fact

SUMMARY
Remove previously deprecated ec2_elb fact from elb_classic_lb this only every returned the value 'info'.
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
elb_classic_lb
ADDITIONAL INFORMATION
See also ansible-collections#552 and ansible-collections#377 for some of the history.

Reviewed-by: Alina Buzachis <None>
abikouo pushed a commit to abikouo/community.aws that referenced this issue Oct 24, 2023
…lections#562)

rds_subnet_group: Add tags feature and enable check_mode

SUMMARY

rds_subnet_group: Add tags feature and enable check_mode
Fixes: ansible-collections#552

Depends-On: ansible-collections/amazon.aws#553
ISSUE TYPE

Feature Pull Request

COMPONENT NAME

rds_subnet_group

Reviewed-by: Jill R <None>
Reviewed-by: Mark Chappell <None>
Reviewed-by: Alina Buzachis <None>
Reviewed-by: Mark Woolley <mw@marknet15.com>
Reviewed-by: Markus Bergholz <git@osuv.de>

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections@ce599bd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue/PR relates to a bug module module plugins plugin (any type)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants