Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch to boto3 in route53 module #377

Closed
aogier opened this issue Jan 30, 2021 · 4 comments
Closed

switch to boto3 in route53 module #377

aogier opened this issue Jan 30, 2021 · 4 comments
Labels
feature This issue/PR relates to a feature request module module plugins plugin (any type) python3

Comments

@aogier
Copy link

aogier commented Jan 30, 2021

SUMMARY

Hello, I have a number of playbooks that I'd like to schedule on a k8s cluster. This cluster is on EKS with IAM serviceaccounts mapping enabled, that's a neat feature that lower a lot management efforts and I love it. So far so good, but unfortunately boto-based modules does not support this feature as it seems boto itself is unsupported. I'd like to port route53 module, which is what I need today, to boto3. I've seen the code and that's seems feasible to me, but I'd like to coordinate with preexistent efforts (if any) before I begin.

ISSUE TYPE
  • Feature Idea
COMPONENT NAME

route53

ANSIBLE VERSION

ansible 2.10.4
  config file = None
  configured module search path = ['/home/ansible/.ansible/plugins/modules', '/usr/share/ansible/plugins/modules']
  ansible python module location = /usr/lib/python3.8/site-packages/ansible
  executable location = /usr/bin/ansible
  python version = 3.8.7 (default, Dec 26 2020, 08:45:55) [GCC 10.2.1 20201203]
ADDITIONAL INFORMATION

This upgrade could let users exploit IAM mapping on EKS clusters (maybe others) instead of the usual key/secret combo alone (which obviously has to be supported).

WDYT? Ciao!

@ansibullbot
Copy link

Files identified in the description:

If these files are inaccurate, please update the component name section of the description or use the !component bot command.

click here for bot help

@ansibullbot
Copy link

@aogier: Greetings! Thanks for taking the time to open this issue. In order for the community to handle your issue effectively, we need a bit more information.

Here are the items we could not find in your description:

  • ansible version

Please set the description of this issue with this template:
https://raw.githubusercontent.com/ansible/ansible/devel/.github/ISSUE_TEMPLATE/bug_report.md

click here for bot help

@ansibullbot
Copy link

@ansibullbot ansibullbot added module module needs_info This issue requires further information. Please answer any outstanding questions needs_template This issue/PR has an incomplete description. Please fill in the proposed template correctly needs_triage plugins plugin (any type) feature This issue/PR relates to a feature request python3 and removed needs_info This issue requires further information. Please answer any outstanding questions needs_template This issue/PR has an incomplete description. Please fill in the proposed template correctly labels Jan 30, 2021
@gravesm
Copy link
Member

gravesm commented Mar 19, 2021

@aogier thank you for filing the issue. This was done in #405 and will be included in the next release.

@gravesm gravesm closed this as completed Mar 19, 2021
alinabuzachis pushed a commit to alinabuzachis/community.aws that referenced this issue May 25, 2022
ec2_elb_lb boto3 migration

SUMMARY
Rewrite ec2_elb_lb using the boto3 SDK
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
ec2_elb_lb
ADDITIONAL INFORMATION
Current state

 renamed to elb_classic_lb
 create/delete ELBs
 change schema
 update availability-zones
 update subnets
 manage tags
 manage listeners
 manage health checks
 manage cross-AZ balancing
 manage draining
 manage idle_timeout
 manage backend policies
 manage stickiness
 manage Instance attachment
 manage access logging
 lookup SGs by name
 parameter validation (protocol, mandatory on creation etc)

Depends-On: ansible/ansible-zuul-jobs#1097

Reviewed-by: Jill R <None>
Reviewed-by: Alina Buzachis <None>
Reviewed-by: Mark Chappell <None>
Reviewed-by: None <None>
alinabuzachis pushed a commit to alinabuzachis/community.aws that referenced this issue May 25, 2022
elb_classic_lb - deprecate the ec2_elb fact

SUMMARY
deprecates the ec2_elb fact in favour of the elb return value.
Split off from ansible-collections#377
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
elb_classic_lb
ADDITIONAL INFORMATION
(yes, this module set a fact with the same name, but different content, as the elb_instance module.)

Reviewed-by: Alina Buzachis <None>
Reviewed-by: None <None>
abikouo pushed a commit to abikouo/community.aws that referenced this issue Oct 24, 2023
elb_classic_lb - Remove deprecated ec2_elb fact

SUMMARY
Remove previously deprecated ec2_elb fact from elb_classic_lb this only every returned the value 'info'.
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
elb_classic_lb
ADDITIONAL INFORMATION
See also ansible-collections#552 and ansible-collections#377 for some of the history.

Reviewed-by: Alina Buzachis <None>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature This issue/PR relates to a feature request module module plugins plugin (any type) python3
Projects
None yet
Development

No branches or pull requests

3 participants