Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ssm_parameter: update examples to use FQCN #1685

Merged
merged 5 commits into from
Aug 7, 2023
Merged

ssm_parameter: update examples to use FQCN #1685

merged 5 commits into from
Aug 7, 2023

Conversation

mandar242
Copy link
Contributor

SUMMARY

This PR update examples to use FQCN.
Fixes #1581

Should get reflected in module documentation on next doc generation.

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

amazon.aws.ssm_parameter

ADDITIONAL INFORMATION

@github-actions
Copy link

github-actions bot commented Aug 2, 2023 •
edited
Loading

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/a5221bfbfe314d0c8e4293eac6994575

✔️ ansible-galaxy-importer SUCCESS in 3m 54s
✔️ build-ansible-collection SUCCESS in 12m 37s
✔️ ansible-test-splitter SUCCESS in 5m 00s
✔️ integration-amazon.aws-1 SUCCESS in 8m 03s
Skipped 43 jobs

@alinabuzachis alinabuzachis added backport-5 PR should be backported to the stable-5 branch backport-6 PR should be backported to the stable-6 branch labels Aug 4, 2023
@alinabuzachis alinabuzachis added this to the 6.4.0 milestone Aug 4, 2023
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/d8fbe9e0f4914d2daa94d8a052fa80a0

✔️ ansible-galaxy-importer SUCCESS in 4m 53s
✔️ build-ansible-collection SUCCESS in 13m 20s
✔️ ansible-test-splitter SUCCESS in 5m 38s
✔️ integration-amazon.aws-1 SUCCESS in 6m 43s
Skipped 43 jobs

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/b6e4bfae185847fc9fede44f46d617f3

✔️ ansible-galaxy-importer SUCCESS in 6m 17s
✔️ build-ansible-collection SUCCESS in 13m 02s
✔️ ansible-test-splitter SUCCESS in 5m 06s
✔️ integration-amazon.aws-1 SUCCESS in 7m 23s
Skipped 43 jobs

@mandar242 mandar242 added backport-5 PR should be backported to the stable-5 branch backport-6 PR should be backported to the stable-6 branch mergeit Merge the PR (SoftwareFactory) and removed backport-5 PR should be backported to the stable-5 branch backport-6 PR should be backported to the stable-6 branch labels Aug 7, 2023
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/170d1fb361bb4017b3f601464c76e09e

✔️ ansible-galaxy-importer SUCCESS in 4m 47s
✔️ build-ansible-collection SUCCESS in 15m 30s
✔️ ansible-test-splitter SUCCESS in 5m 08s
✔️ integration-amazon.aws-1 SUCCESS in 7m 13s
Skipped 43 jobs

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 44eec36 into ansible-collections:main Aug 7, 2023
@patchback
Copy link

patchback bot commented Aug 7, 2023 •
edited
Loading

Backport to stable-5: 💔 cherry-picking failed — conflicts found

❌ Failed to cleanly apply 44eec36 on top of patchback/backports/stable-5/44eec363fe9e069cd3c17b792c063e2317bd153b/pr-1685

Backporting merged PR #1685 into main

  1. Ensure you have a local repo clone of your fork. Unless you cloned it
    from the upstream, this would be your origin remote.
  2. Make sure you have an upstream repo added as a remote too. In these
    instructions you'll refer to it by the name upstream. If you don't
    have it, here's how you can add it: 
    $ git remote add upstream https://github.com/ansible-collections/amazon.aws.git
  3. Ensure you have the latest copy of upstream and prepare a branch
    that will hold the backported code: 
    $ git fetch upstream
$ git checkout -b patchback/backports/stable-5/44eec363fe9e069cd3c17b792c063e2317bd153b/pr-1685 upstream/stable-5
  4. Now, cherry-pick PR ssm_parameter: update examples to use FQCN #1685 contents into that branch: 
    $ git cherry-pick -x 44eec363fe9e069cd3c17b792c063e2317bd153b
    If it'll yell at you with something like fatal: Commit 44eec363fe9e069cd3c17b792c063e2317bd153b is a merge but no -m option was given., add -m 1 as follows instead: 
    $ git cherry-pick -m1 -x 44eec363fe9e069cd3c17b792c063e2317bd153b
  5. At this point, you'll probably encounter some merge conflicts. You must
    resolve them in to preserve the patch from PR ssm_parameter: update examples to use FQCN #1685 as close to the
    original as possible.
  6. Push this branch to your fork on GitHub: 
    $ git push origin patchback/backports/stable-5/44eec363fe9e069cd3c17b792c063e2317bd153b/pr-1685
  7. Create a PR, ensure that the CI is green. If it's not — update it so that
    the tests and any other checks pass. This is it!
    Now relax and wait for the maintainers to process your pull request
    when they have some cycles to do reviews. Don't worry — they'll tell you if
    any improvements are necessary when the time comes!

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@patchback
Copy link

patchback bot commented Aug 7, 2023 •
edited
Loading

Backport to stable-6: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-6/44eec363fe9e069cd3c17b792c063e2317bd153b/pr-1685

Backported as #1692

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Aug 7, 2023
@mandar242 @patchback
ssm_parameter: update examples to use FQCN (#1685)
058f1f8 
ssm_parameter: update examples to use FQCN

SUMMARY

This PR update examples to use FQCN.
Fixes #1581
Should get reflected in module documentation on next doc generation.

ISSUE TYPE

Docs Pull Request

COMPONENT NAME

amazon.aws.ssm_parameter
ADDITIONAL INFORMATION

Reviewed-by: Alina Buzachis
(cherry picked from commit 44eec36)
@patchback patchback bot mentioned this pull request Aug 7, 2023
Merged
alinabuzachis pushed a commit to alinabuzachis/amazon.aws that referenced this pull request Aug 8, 2023
@mandar242 @alinabuzachis
ssm_parameter: update examples to use FQCN (ansible-collections#1685)
363084b 
ssm_parameter: update examples to use FQCN

SUMMARY

This PR update examples to use FQCN.
Fixes ansible-collections#1581
Should get reflected in module documentation on next doc generation.

ISSUE TYPE

Docs Pull Request

COMPONENT NAME

amazon.aws.ssm_parameter
ADDITIONAL INFORMATION

Reviewed-by: Alina Buzachis
(cherry picked from commit 44eec36)
softwarefactory-project-zuul bot pushed a commit that referenced this pull request Aug 8, 2023
@patchback
ssm_parameter: update examples to use FQCN (#1685) (#1692)
0a30d93 
[PR #1685/44eec363 backport][stable-6] ssm_parameter: update examples to use FQCN

This is a backport of PR #1685 as merged into main (44eec36).
SUMMARY

This PR update examples to use FQCN.
Fixes #1581
Should get reflected in module documentation on next doc generation.

ISSUE TYPE


Docs Pull Request

COMPONENT NAME

amazon.aws.ssm_parameter
ADDITIONAL INFORMATION

Reviewed-by: Alina Buzachis
softwarefactory-project-zuul bot pushed a commit that referenced this pull request Aug 8, 2023
@alinabuzachis
ssm_parameter: update examples to use FQCN (#1685) (#1693)
cf72e21 
[manual backport stable-5] ssm_parameter: update examples to use FQCN (#1685)

ssm_parameter: update examples to use FQCN
SUMMARY
This PR update examples to use FQCN.
Fixes #1581
Should get reflected in module documentation on next doc generation.
ISSUE TYPE
Docs Pull Request
COMPONENT NAME
amazon.aws.ssm_parameter
ADDITIONAL INFORMATION
Reviewed-by: Alina Buzachis
(cherry picked from commit 44eec36)
SUMMARY


ISSUE TYPE


Bugfix Pull Request
Docs Pull Request
Feature Pull Request
New Module Pull Request

COMPONENT NAME

ADDITIONAL INFORMATION

Reviewed-by: Mandar Kulkarni <mandar242@gmail.com>
Reviewed-by: Jill R
krisek pushed a commit to krisek/amazon.aws that referenced this pull request Aug 31, 2023
@mandar242 @krisek
ssm_parameter: update examples to use FQCN (ansible-collections#1685)
bcd3ca7 
ssm_parameter: update examples to use FQCN

SUMMARY

This PR update examples to use FQCN.
Fixes ansible-collections#1581
Should get reflected in module documentation on next doc generation.

ISSUE TYPE


Docs Pull Request

COMPONENT NAME

amazon.aws.ssm_parameter
ADDITIONAL INFORMATION

Reviewed-by: Alina Buzachis
@mandar242 mandar242 deleted the ssm_doc_fix branch October 29, 2024 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alinabuzachis alinabuzachis alinabuzachis approved these changes

Assignees
No one assigned
Labels
backport-5 PR should be backported to the stable-5 branch backport-6 PR should be backported to the stable-6 branch community_review docs lookup lookup plugin mergeit Merge the PR (SoftwareFactory) needs_triage plugins plugin (any type)
Projects
None yet
Milestone
6.4.0
Development

Successfully merging this pull request may close these issues.

Lack of FQCN on aws.ssm docs
3 participants
@mandar242 @alinabuzachis @ansibullbot