Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lack of FQCN on aws.ssm docs #1581

Closed
1 task done
jlosito opened this issue May 30, 2023 · 2 comments · Fixed by #1685
Closed
1 task done

Lack of FQCN on aws.ssm docs #1581

jlosito opened this issue May 30, 2023 · 2 comments · Fixed by #1685
Assignees
@mandar242
Labels
docs has_pr waiting_on_contributor Needs help. Feel free to engage to get things unblocked

Comments

@jlosito
Copy link

jlosito commented May 30, 2023 •
edited
Loading

Summary

In each of the examples on SSM documentation page linked below, it doesn't have the FQCN for the module.

https://docs.ansible.com/ansible/latest/collections/amazon/aws/aws_ssm_lookup.html

Should it given that everywhere is recommending to use FQCN? Also ansible-lint is now marking those lines that don't have FQCN.

Issue Type

Documentation Report

Component Name

aws_ssm

Ansible Version

No response

Collection Versions

No response

Configuration

No response

OS / Environment

No response

Additional Information

No response

Code of Conduct

  • I agree to follow the Ansible Code of Conduct
@jillr jillr added waiting_on_contributor Needs help. Feel free to engage to get things unblocked and removed needs_triage labels May 30, 2023
@alinabuzachis
Copy link
Collaborator

@jlosito Thank you for raising this issue. Would you be willing to open a Pull Request with a fix? Thank you.

@jlosito
Copy link
Author

jlosito commented May 31, 2023

@alinabuzachis yes. It should be a trivial change.

@mandar242 mandar242 mentioned this issue Aug 2, 2023
Merged
@mandar242 mandar242 self-assigned this Aug 2, 2023
softwarefactory-project-zuul bot pushed a commit that referenced this issue Aug 7, 2023
@mandar242
ssm_parameter: update examples to use FQCN (#1685)
44eec36 
ssm_parameter: update examples to use FQCN

SUMMARY

This PR update examples to use FQCN.
Fixes #1581
Should get reflected in module documentation on next doc generation.

ISSUE TYPE


Docs Pull Request

COMPONENT NAME

amazon.aws.ssm_parameter
ADDITIONAL INFORMATION

Reviewed-by: Alina Buzachis
patchback bot pushed a commit that referenced this issue Aug 7, 2023
@mandar242 @patchback
ssm_parameter: update examples to use FQCN (#1685)
058f1f8 
ssm_parameter: update examples to use FQCN

SUMMARY

This PR update examples to use FQCN.
Fixes #1581
Should get reflected in module documentation on next doc generation.

ISSUE TYPE

Docs Pull Request

COMPONENT NAME

amazon.aws.ssm_parameter
ADDITIONAL INFORMATION

Reviewed-by: Alina Buzachis
(cherry picked from commit 44eec36)
@patchback patchback bot mentioned this issue Aug 7, 2023
Merged
alinabuzachis pushed a commit to alinabuzachis/amazon.aws that referenced this issue Aug 8, 2023
@mandar242 @alinabuzachis
ssm_parameter: update examples to use FQCN (ansible-collections#1685)
363084b 
ssm_parameter: update examples to use FQCN

SUMMARY

This PR update examples to use FQCN.
Fixes ansible-collections#1581
Should get reflected in module documentation on next doc generation.

ISSUE TYPE

Docs Pull Request

COMPONENT NAME

amazon.aws.ssm_parameter
ADDITIONAL INFORMATION

Reviewed-by: Alina Buzachis
(cherry picked from commit 44eec36)
@alinabuzachis alinabuzachis mentioned this issue Aug 8, 2023
Merged
softwarefactory-project-zuul bot pushed a commit that referenced this issue Aug 8, 2023
@patchback
ssm_parameter: update examples to use FQCN (#1685) (#1692)
0a30d93 
[PR #1685/44eec363 backport][stable-6] ssm_parameter: update examples to use FQCN

This is a backport of PR #1685 as merged into main (44eec36).
SUMMARY

This PR update examples to use FQCN.
Fixes #1581
Should get reflected in module documentation on next doc generation.

ISSUE TYPE


Docs Pull Request

COMPONENT NAME

amazon.aws.ssm_parameter
ADDITIONAL INFORMATION

Reviewed-by: Alina Buzachis
softwarefactory-project-zuul bot pushed a commit that referenced this issue Aug 8, 2023
@alinabuzachis
ssm_parameter: update examples to use FQCN (#1685) (#1693)
cf72e21 
[manual backport stable-5] ssm_parameter: update examples to use FQCN (#1685)

ssm_parameter: update examples to use FQCN
SUMMARY
This PR update examples to use FQCN.
Fixes #1581
Should get reflected in module documentation on next doc generation.
ISSUE TYPE
Docs Pull Request
COMPONENT NAME
amazon.aws.ssm_parameter
ADDITIONAL INFORMATION
Reviewed-by: Alina Buzachis
(cherry picked from commit 44eec36)
SUMMARY


ISSUE TYPE


Bugfix Pull Request
Docs Pull Request
Feature Pull Request
New Module Pull Request

COMPONENT NAME

ADDITIONAL INFORMATION

Reviewed-by: Mandar Kulkarni <mandar242@gmail.com>
Reviewed-by: Jill R
krisek pushed a commit to krisek/amazon.aws that referenced this issue Aug 31, 2023
@mandar242 @krisek
ssm_parameter: update examples to use FQCN (ansible-collections#1685)
bcd3ca7 
ssm_parameter: update examples to use FQCN

SUMMARY

This PR update examples to use FQCN.
Fixes ansible-collections#1581
Should get reflected in module documentation on next doc generation.

ISSUE TYPE


Docs Pull Request

COMPONENT NAME

amazon.aws.ssm_parameter
ADDITIONAL INFORMATION

Reviewed-by: Alina Buzachis
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mandar242 mandar242

Labels
docs has_pr waiting_on_contributor Needs help. Feel free to engage to get things unblocked
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ssm_parameter: update examples to use FQCN mandar242/amazon.aws
5 participants
@jillr @jlosito @mandar242 @alinabuzachis @ansibullbot