-
Notifications
You must be signed in to change notification settings - Fork 992
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fee unit tests #2914
Merged
Merged
Fee unit tests #2914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Tiago Carvalho <sugoiuguu@tfwno.gf>
Co-authored-by: Tiago Carvalho <sugoiuguu@tfwno.gf>
Co-authored-by: Tiago Carvalho <sugoiuguu@tfwno.gf>
Co-authored-by: Tiago Carvalho <sugoiuguu@tfwno.gf>
Co-authored-by: Tiago Carvalho <sugoiuguu@tfwno.gf>
Co-authored-by: Tiago Carvalho <sugoiuguu@tfwno.gf>
6685f96
to
0078d3f
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2914 +/- ##
==========================================
- Coverage 53.88% 53.57% -0.31%
==========================================
Files 308 307 -1
Lines 100154 99229 -925
==========================================
- Hits 53966 53163 -803
+ Misses 46188 46066 -122 ☔ View full report in Codecov by Sentry. |
batconjurer
previously approved these changes
Mar 19, 2024
0078d3f
to
ba6f1c3
Compare
tzemanovic
added a commit
that referenced
this pull request
Apr 1, 2024
* grarco/fee-unit-tests: Changelog #2914 Improves unit tests for fee payment
tzemanovic
added a commit
that referenced
this pull request
Apr 1, 2024
tzemanovic
added a commit
that referenced
this pull request
Apr 10, 2024
* origin/grarco/fee-unit-tests: Changelog #2914 Improves unit tests for fee payment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Adds a new unit test to verify that the fee payment is committed even in case the inner tx failed (wasn't needed before the tx queue removal pr).
Improves the
insufficient_balance
test to have an initial balance.Indicate on which release or other PRs this topic is based on
#2819 (diff: 4219d74) rebased on top of v0.31.9
Checklist before merging to
draft