Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fee unit tests #2914

Merged
merged 25 commits into from
Apr 12, 2024
Merged

Fee unit tests #2914

merged 25 commits into from
Apr 12, 2024

Conversation

grarco
Copy link
Collaborator

@grarco grarco commented Mar 18, 2024

Describe your changes

Adds a new unit test to verify that the fee payment is committed even in case the inner tx failed (wasn't needed before the tx queue removal pr).
Improves the insufficient_balance test to have an initial balance.

Indicate on which release or other PRs this topic is based on

#2819 (diff: 4219d74) rebased on top of v0.31.9

Checklist before merging to draft

  • I have added a changelog
  • Git history is in acceptable state

batconjurer and others added 23 commits March 8, 2024 11:52
Co-authored-by: Tiago Carvalho <sugoiuguu@tfwno.gf>
Co-authored-by: Tiago Carvalho <sugoiuguu@tfwno.gf>
Co-authored-by: Tiago Carvalho <sugoiuguu@tfwno.gf>
Co-authored-by: Tiago Carvalho <sugoiuguu@tfwno.gf>
Co-authored-by: Tiago Carvalho <sugoiuguu@tfwno.gf>
Co-authored-by: Tiago Carvalho <sugoiuguu@tfwno.gf>
grarco added a commit that referenced this pull request Mar 18, 2024
grarco added a commit that referenced this pull request Mar 18, 2024
@grarco grarco force-pushed the grarco/fee-unit-tests branch from 6685f96 to 0078d3f Compare March 18, 2024 18:09
Copy link

codecov bot commented Mar 18, 2024

Codecov Report

Attention: Patch coverage is 68.42105% with 192 lines in your changes are missing coverage. Please review.

Project coverage is 53.57%. Comparing base (2ba001d) to head (ba6f1c3).
Report is 135 commits behind head on main.

Files Patch % Lines
crates/sdk/src/masp.rs 0.00% 95 Missing ⚠️
...s/apps/src/lib/node/ledger/shell/finalize_block.rs 88.23% 18 Missing ⚠️
crates/apps/src/lib/bench_utils.rs 0.00% 16 Missing ⚠️
crates/sdk/src/tx.rs 0.00% 14 Missing ⚠️
...ates/apps/src/lib/node/ledger/shell/block_alloc.rs 89.47% 12 Missing ⚠️
crates/apps/src/lib/client/rpc.rs 0.00% 8 Missing ⚠️
crates/apps/src/lib/node/ledger/shell/mod.rs 36.36% 7 Missing ⚠️
.../apps/src/lib/node/ledger/shell/vote_extensions.rs 66.66% 6 Missing ⚠️
...apps/src/lib/node/ledger/shell/process_proposal.rs 77.27% 5 Missing ⚠️
...tes/apps/src/lib/node/ledger/shell/testing/node.rs 0.00% 3 Missing ⚠️
... and 8 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2914      +/-   ##
==========================================
- Coverage   53.88%   53.57%   -0.31%     
==========================================
  Files         308      307       -1     
  Lines      100154    99229     -925     
==========================================
- Hits        53966    53163     -803     
+ Misses      46188    46066     -122     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@grarco grarco marked this pull request as ready for review March 18, 2024 18:42
@grarco grarco requested a review from batconjurer March 18, 2024 18:42
batconjurer
batconjurer previously approved these changes Mar 19, 2024
@tzemanovic tzemanovic force-pushed the grarco/fee-unit-tests branch from 0078d3f to ba6f1c3 Compare April 1, 2024 09:24
tzemanovic added a commit that referenced this pull request Apr 1, 2024
* grarco/fee-unit-tests:
  Changelog #2914
  Improves unit tests for fee payment
tzemanovic added a commit that referenced this pull request Apr 10, 2024
* origin/grarco/fee-unit-tests:
  Changelog #2914
  Improves unit tests for fee payment
@tzemanovic tzemanovic merged commit 1569414 into main Apr 12, 2024
12 of 19 checks passed
@tzemanovic tzemanovic deleted the grarco/fee-unit-tests branch April 12, 2024 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants