Fix allowlist checks #2819
Merged
Fix allowlist checks #2819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2819 +/- ##
==========================================
- Coverage 53.88% 53.56% -0.32%
==========================================
Files 308 307 -1
Lines 100154 99228 -926
==========================================
- Hits 53966 53156 -810
+ Misses 46188 46072 -116 ☔ View full report in Codecov by Sentry. |
tzemanovic
reviewed
Mar 7, 2024
Co-authored-by: Tiago Carvalho <sugoiuguu@tfwno.gf>
Co-authored-by: Tiago Carvalho <sugoiuguu@tfwno.gf>
Co-authored-by: Tiago Carvalho <sugoiuguu@tfwno.gf>
Co-authored-by: Tiago Carvalho <sugoiuguu@tfwno.gf>
Co-authored-by: Tiago Carvalho <sugoiuguu@tfwno.gf>
Co-authored-by: Tiago Carvalho <sugoiuguu@tfwno.gf>
tzemanovic
previously approved these changes
Mar 18, 2024
7967b62 to
c76bead
Compare
|
I rebased on updated #2627 |
tzemanovic
added a commit
that referenced
this pull request
Mar 18, 2024
* grarco/allowlist-fix: Changelog #2819 Fixes and improves allowlist test Improves tx allowlist error. Tx allowlist check in mempool and `process_proposal` Moves tx allowlist check to allow replay protection optimizations Ensures fee payment even in case of unallowed wasm code Updates governance test to cover vp allowlist
tzemanovic
added a commit
that referenced
this pull request
Mar 19, 2024
* grarco/allowlist-fix: Changelog #2819 Fixes and improves allowlist test Improves tx allowlist error. Tx allowlist check in mempool and `process_proposal` Moves tx allowlist check to allow replay protection optimizations Ensures fee payment even in case of unallowed wasm code Updates governance test to cover vp allowlist
tzemanovic
added a commit
that referenced
this pull request
Apr 10, 2024
* origin/grarco/allowlist-fix: Changelog #2819 Fixes and improves allowlist test Improves tx allowlist error. Tx allowlist check in mempool and `process_proposal` Moves tx allowlist check to allow replay protection optimizations Ensures fee payment even in case of unallowed wasm code Updates governance test to cover vp allowlist # Conflicts: # wasm_for_tests/tx_fail.wasm # wasm_for_tests/tx_memory_limit.wasm # wasm_for_tests/tx_mint_tokens.wasm # wasm_for_tests/tx_no_op.wasm # wasm_for_tests/tx_proposal_code.wasm # wasm_for_tests/tx_proposal_masp_reward.wasm # wasm_for_tests/tx_read_storage_key.wasm # wasm_for_tests/tx_write.wasm # wasm_for_tests/tx_write_storage_key.wasm # wasm_for_tests/vp_always_false.wasm # wasm_for_tests/vp_always_true.wasm # wasm_for_tests/vp_eval.wasm # wasm_for_tests/vp_memory_limit.wasm # wasm_for_tests/vp_read_storage_key.wasm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Closes #2770.
Moves the check on the tx allowlist to always enforce fee payment. Also performs this check after the check on the code section commitment to allow replay protection to do some optimizations.
Indicate on which release or other PRs this topic is based on
#2627 (diff: https://github.com/anoma/namada/pull/2819/files/e138cfb7604744a45b8a84fc16a52ae86ec1c73f..c76beadbe7c3f524be175a1dfbf7b2a229039bd8)
Checklist before merging to
draft