Runtime gas meter #2838
Merged
Runtime gas meter #2838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2838 +/- ##
==========================================
+ Coverage 53.88% 53.92% +0.04%
==========================================
Files 308 308
Lines 100154 100479 +325
==========================================
+ Hits 53967 54186 +219
- Misses 46187 46293 +106 ☔ View full report in Codecov by Sentry. |
1ad1048 to
a28e64b
Compare
7dfa159 to
571dba2
Compare
tzemanovic
reviewed
Mar 19, 2024
tzemanovic
previously approved these changes
Mar 19, 2024
2 tasks
tzemanovic
added a commit
that referenced
this pull request
Mar 28, 2024
* origin/grarco/runtime-gas-meter: Test that native VPs correctly run out of gas Empty loop in out of gas unit tests Adds source for wasm gas costs Changelog #2838 Increases gas limits in unit tests Increases gas scale Gas metering in `PseudoExecutionContext` Updates gas costs Singlepass compiler for wasm benchmarks Iterations and improvements for wasm opcodes benchmarks Removes old comment Renames vp user benchmark Updates beatch size for benchmarks Fixes make clippy for benchmarks Higher resolution gas metering for masp Updates masp vp checks Removes testing dependency from the benchmarks crate Clippy + fmt Removes benchmark for vp validator Benchmarks for shielded actions Adds wasm opcodes benchmarks Changes docstrings for signature verification Adds unit tests for out of gas Gas for ibc tx and removes unused host fn for whitelisted gas Removes whitelisted gas and sets a constant for the runtime gas meter
tzemanovic
added a commit
that referenced
this pull request
Mar 31, 2024
tzemanovic
added a commit
that referenced
this pull request
Apr 10, 2024
* origin/grarco/runtime-gas-meter: Test that native VPs correctly run out of gas Empty loop in out of gas unit tests Adds source for wasm gas costs Changelog #2838 Increases gas limits in unit tests Increases gas scale Gas metering in `PseudoExecutionContext` Updates gas costs Singlepass compiler for wasm benchmarks Iterations and improvements for wasm opcodes benchmarks Removes old comment Renames vp user benchmark Updates beatch size for benchmarks Fixes make clippy for benchmarks Higher resolution gas metering for masp Updates masp vp checks Removes testing dependency from the benchmarks crate Clippy + fmt Removes benchmark for vp validator Benchmarks for shielded actions Adds wasm opcodes benchmarks Changes docstrings for signature verification Adds unit tests for out of gas Gas for ibc tx and removes unused host fn for whitelisted gas Removes whitelisted gas and sets a constant for the runtime gas meter # Conflicts: # crates/apps/src/lib/bench_utils.rs # crates/apps/src/lib/node/ledger/shell/finalize_block.rs # crates/benches/Cargo.toml # crates/benches/native_vps.rs # crates/benches/txs.rs # crates/core/Cargo.toml # crates/macros/src/lib.rs # crates/namada/Cargo.toml # crates/namada/src/ledger/protocol/mod.rs # crates/namada/src/vm/host_env.rs # crates/namada/src/vm/wasm/run.rs # crates/state/Cargo.toml # crates/test_utils/src/lib.rs # wasm/wasm_source/src/tx_ibc.rs # wasm_for_tests/tx_fail.wasm # wasm_for_tests/tx_memory_limit.wasm # wasm_for_tests/tx_mint_tokens.wasm # wasm_for_tests/tx_no_op.wasm # wasm_for_tests/tx_proposal_code.wasm # wasm_for_tests/tx_proposal_masp_reward.wasm # wasm_for_tests/tx_read_storage_key.wasm # wasm_for_tests/tx_write.wasm # wasm_for_tests/tx_write_storage_key.wasm # wasm_for_tests/vp_always_false.wasm # wasm_for_tests/vp_always_true.wasm # wasm_for_tests/vp_eval.wasm # wasm_for_tests/vp_memory_limit.wasm # wasm_for_tests/vp_read_storage_key.wasm # wasm_for_tests/wasm_source/Cargo.toml # wasm_for_tests/wasm_source/Makefile
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Closes #2816.
Closes #2674.
This PR:
vp_validator(no longer existing)testingfeature from the benchmark crate which was pulling in some mock functions that should not be used in benchmarksConstantGasRuleswith a custom one based on the benchmarksPseudoExecutionContextSCALEfor the now increased gas costs to keep the average cost of a tx around 20_000 gas unitsThe runtime gas meter has the following drawbacks:
Indicate on which release or other PRs this topic is based on
v0.31.9
Checklist before merging to
draft