Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Benchmarks improvements #2674

Closed
Tracked by #2530
grarco opened this issue Feb 20, 2024 · 0 comments · Fixed by #2838
Closed
Tracked by #2530

Benchmarks improvements #2674

grarco opened this issue Feb 20, 2024 · 0 comments · Fixed by #2838
Assignees
Labels
gas pre-mainnet Must happen before mainnet.

Comments

@grarco
Copy link
Collaborator

grarco commented Feb 20, 2024

We should try to improve the benchmarks (if possible) with the followings:

  • Review the benchmarks for IBC transactions (we've added new features since the benches were written)
  • Split the benchmark of verify_shielded_tx in the masp VP into separate benches for check_spend, check_convert, check_output and final_check so that we can better track gas at runtime depending on the number of notes in the transaction
  • Refactor run::tx and run::vp to avoid benchmarking the call to fetch_and_compile (which is already tracked separately)
@grarco grarco added gas pre-mainnet Must happen before mainnet. labels Feb 20, 2024
@grarco grarco self-assigned this Feb 20, 2024
@grarco grarco mentioned this issue Mar 10, 2024
2 tasks
@brentstone brentstone added this to the Phase 1: mainnet genesis milestone Apr 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gas pre-mainnet Must happen before mainnet.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants