Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

md-fab button in md-toolbar has white background #1687

Closed
Toilal opened this issue Feb 26, 2015 · 3 comments
Closed

md-fab button in md-toolbar has white background #1687

Toilal opened this issue Feb 26, 2015 · 3 comments
Milestone
0.9.0

Comments

@Toilal
Copy link
Contributor

Toilal commented Feb 26, 2015

I thing there's a problem with styling in button-theme.scss. It cause md-fab button embeded in md-toolbar to have white background, regardless the theme.

Plunkr showing the issue
@Toilal
Copy link
Contributor Author

Toilal commented Feb 26, 2015

It's related to #1223, but I don't think simply setting the background to white was the best solution ... It makes icon not visible, and it's not consistent with colors applied when moving mouse over or clicking the button.

Toilal added a commit to Toilal/material that referenced this issue Feb 26, 2015
@Toilal
fix(button): Use md-raised colors for md-fab included in md-toolbar
66d2a7d 
Instead of using a white background, use the same styles as md-raised buttons for md-fab buttons included in md-toolbar.

It allows md-fab buttons included in md-toolbar to support all rendering effects properly.

Close angular#1687
@Toilal Toilal mentioned this issue Feb 26, 2015
Closed
@ThomasBurleson ThomasBurleson modified the milestone: 0.9.0 Mar 12, 2015
@birdcw
Copy link

birdcw commented Mar 16, 2015

I've noticed white fabs like this in iOS, but not in anything else that I've tried. They only get their color when clicked.

@marcysutton
Copy link
Contributor

Hi, can you repost your Plunker? The link is no longer working. @Toilal

marcysutton pushed a commit that referenced this issue Mar 27, 2015
fix(mdButton): revert background color
3180d98 
FAB buttons in #1223 work without the fix added to close that issue, so the white background color has been removed.

Closes #1687
@marcysutton marcysutton mentioned this issue Mar 27, 2015
Closed
marcysutton pushed a commit that referenced this issue Mar 27, 2015
fix(mdButton): revert background color
18748a1 
FAB buttons in #1223 work without the fix added to close that issue, so the white background color has been removed.

Closes #1687
marcysutton pushed a commit that referenced this issue Mar 27, 2015
fix(button): hover, disabled, alignment, docs
af9e317 
Includes component fixes after global CSS updates

Closes #1607, #1687, #1690, #1832, #1907, #1987, #2009
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.9.0
Development

Successfully merging a pull request may close this issue.

fix(button): Use md-raised colors for md-fab included in md-toolbar Toilal/material
4 participants
@ThomasBurleson @marcysutton @Toilal @birdcw