Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

md-button fab with ng-href change icon position #1607

Closed
luclanet opened this issue Feb 21, 2015 · 5 comments
Closed

md-button fab with ng-href change icon position #1607

luclanet opened this issue Feb 21, 2015 · 5 comments
Assignees
@marcysutton
Milestone
0.9.0

Comments

@luclanet
Copy link

image
First with "ng-href", second one without.
@marcysutton
Copy link
Contributor

That means anchors and buttons inside of md-button have slightly different styles...ng-href creates an child <a> element instead of <button>. Should be an easy fix, want to create a PR?

@luclanet
Copy link
Author

What's a PR?

@ruiaraujo
Copy link
Contributor

@luclanet pull request, ie, fix it. ;)

@ruiaraujo ruiaraujo mentioned this issue Feb 23, 2015
Closed
@iainmcgin
Copy link

I've been playing with this in codepen (http://codepen.io/iainmcgin/pen/wBjqyB), I have a proposed fix using absolute positioning for the icon within fabs, but it's kind of ugly and I hope someone finds a better way. Will create a pull request and let everyone discuss it there.

@iainmcgin
Copy link

The fix from @ruiaraujo looks good, and is included in my codepen for comparison.

@ThomasBurleson ThomasBurleson added this to the 0.9.0 milestone Mar 12, 2015
@marcysutton marcysutton self-assigned this Mar 20, 2015
marcysutton pushed a commit that referenced this issue Mar 23, 2015
fix(button): alignment of FAB + mini anchor btns
97467cb 
Closes #1607, #1690
marcysutton pushed a commit that referenced this issue Mar 24, 2015
fix(button): alignment of FAB + mini anchor btns
6412873 
Also includes .md-mini documentation

Closes #1607, #2009, #1690
marcysutton pushed a commit that referenced this issue Mar 27, 2015
fix(button): alignment of FAB + mini anchor btns
cdccb41 
Also includes .md-mini documentation

Closes #1607, #2009, #1690
@marcysutton marcysutton mentioned this issue Mar 27, 2015
Closed
marcysutton pushed a commit that referenced this issue Mar 27, 2015
fix(button): hover, disabled, alignment, docs
af9e317 
Includes component fixes after global CSS updates

Closes #1607, #1687, #1690, #1832, #1907, #1987, #2009
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@marcysutton marcysutton

Labels
None yet
Projects
None yet
Milestone
0.9.0
Development

No branches or pull requests
5 participants
@ThomasBurleson @ruiaraujo @iainmcgin @marcysutton @luclanet