build(docs-infra): upgrade @angular/cli to 8.0.0-beta.15, @angular/* to 8.0.0-beta.12, @angular/material to 8.0.0-beta.2 #29926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3924734 to
8c47edb
Compare
097ecd5 to
efd0289
Compare
346f8a6 to
5d0af5e
Compare
filipesilva
reviewed
Apr 18, 2019
There was a problem hiding this comment.
Can you also re-enable these tests please? 4d37a06
I know we have already talked about it but wanted to leave a comment here so I don't forget to check :D
gkalpak
added a commit
to gkalpak/angular
that referenced
this pull request
Apr 18, 2019
In angular#29926, the size of the build artifacts has increased due to turning on differential loading (which generates an es2015/es5 pair for each JS resource). To avoid the preview server's rejecting the build artifacts (as in [288181][1]), this commit increases the max allowed artifact size from 20MB to 25MB (current artifact size after angular#29926 is ~22MB). [1]: https://circleci.com/gh/angular/angular/288181
|
AFAICT, these tests are not related to the aio app's cli version (which is independent of the version used in docs examples). |
16 tasks
bf28bcf to
e83ef61
Compare
|
You can preview bf28bcf at https://pr29926-bf28bcf.ngbuilds.io/. |
|
You can preview e83ef61 at https://pr29926-e83ef61.ngbuilds.io/. |
e83ef61 to
af27758
Compare
Now that defferential loading it supported by the cli, remove the obsolete `ie-polyfills.js` (and associated dependencies). All polyfills in `ie-polyfills.js` are now included in the [polyfills-es5][1] bundle, except for `classlist.js`, that is only needed in order to support `NgClass` on SVG elements, which we don't use. [1]: https://github.com/angular/angular-cli/blob/b95933a57/packages/angular_devkit/build_angular/src/angular-cli-files/models/es5-polyfills.js
This commit also changes the `tslint.json` config file to (reasonably closely) match what the cli would generate for a new app.
…o `ban` The `no-jasmine-focus` rule has been removed from `vrsource-tslint-rules` [since version 5.8.0][1] (theoretically; practically it remained [until version 5.8.2][2]). This commit removes the non-existent rule (and the obsolete dependency) and uses tslint's `ban` rule instead (as recommended). [1]: vrsource/vrsource-tslint-rules@477f622#diff-04c6e90faac2675aa89e2176d2eec7d8R162 [2]: vrsource/vrsource-tslint-rules#13 (comment)
e62ebc8 to
488e950
Compare
|
Thx to @clydin's help, I was able to overcome the error by upgrading For reference, here are the |
|
You can preview 488e950 at https://pr29926-488e950.ngbuilds.io/. |
|
Removing "cleanup" label from this PR after a chat with @gkalpak, so this PR is ready to merge. |
brandonroberts
pushed a commit
to brandonroberts/angular
that referenced
this pull request
Apr 25, 2019
brandonroberts
pushed a commit
to brandonroberts/angular
that referenced
this pull request
Apr 25, 2019
This commit also changes the config files and their layout to (reasonably closely) match what the cli would generate for a new app. Related Jira issue: [TOOL-815](https://angular-team.atlassian.net/browse/TOOL-815) PR Close angular#29926
brandonroberts
pushed a commit
to brandonroberts/angular
that referenced
this pull request
Apr 25, 2019
Now that defferential loading it supported by the cli, remove the obsolete `ie-polyfills.js` (and associated dependencies). All polyfills in `ie-polyfills.js` are now included in the [polyfills-es5][1] bundle, except for `classlist.js`, that is only needed in order to support `NgClass` on SVG elements, which we don't use. [1]: https://github.com/angular/angular-cli/blob/b95933a57/packages/angular_devkit/build_angular/src/angular-cli-files/models/es5-polyfills.js PR Close angular#29926
brandonroberts
pushed a commit
to brandonroberts/angular
that referenced
this pull request
Apr 25, 2019
brandonroberts
pushed a commit
to brandonroberts/angular
that referenced
this pull request
Apr 25, 2019
…ngular#29926) This commit also changes the `tslint.json` config file to (reasonably closely) match what the cli would generate for a new app. PR Close angular#29926
brandonroberts
pushed a commit
to brandonroberts/angular
that referenced
this pull request
Apr 25, 2019
…o `ban` (angular#29926) The `no-jasmine-focus` rule has been removed from `vrsource-tslint-rules` [since version 5.8.0][1] (theoretically; practically it remained [until version 5.8.2][2]). This commit removes the non-existent rule (and the obsolete dependency) and uses tslint's `ban` rule instead (as recommended). [1]: vrsource/vrsource-tslint-rules@477f622#diff-04c6e90faac2675aa89e2176d2eec7d8R162 [2]: vrsource/vrsource-tslint-rules#13 (comment) PR Close angular#29926
BioPhoton
pushed a commit
to BioPhoton/angular
that referenced
this pull request
May 21, 2019
…re robust (angular#29989) In light of angular#29926, that will change the path of `tsconfig.app.json`, this commit switches from a hard-coded `tsconfig.app.json` path to looking it up in `angular.json` (to be more future-proof). PR Close angular#29989
BioPhoton
pushed a commit
to BioPhoton/angular
that referenced
this pull request
May 21, 2019
…ver (angular#29976) In angular#29926, the size of the build artifacts has increased due to turning on differential loading (which generates an es2015/es5 pair for each JS resource). To avoid the preview server's rejecting the build artifacts (as in [288181][1]), this commit increases the max allowed artifact size from 20MB to 25MB (current artifact size after angular#29926 is ~22MB). [1]: https://circleci.com/gh/angular/angular/288181 PR Close angular#29976
BioPhoton
pushed a commit
to BioPhoton/angular
that referenced
this pull request
May 21, 2019
BioPhoton
pushed a commit
to BioPhoton/angular
that referenced
this pull request
May 21, 2019
BioPhoton
pushed a commit
to BioPhoton/angular
that referenced
this pull request
May 21, 2019
This commit also changes the config files and their layout to (reasonably closely) match what the cli would generate for a new app. Related Jira issue: [TOOL-815](https://angular-team.atlassian.net/browse/TOOL-815) PR Close angular#29926
BioPhoton
pushed a commit
to BioPhoton/angular
that referenced
this pull request
May 21, 2019
Now that defferential loading it supported by the cli, remove the obsolete `ie-polyfills.js` (and associated dependencies). All polyfills in `ie-polyfills.js` are now included in the [polyfills-es5][1] bundle, except for `classlist.js`, that is only needed in order to support `NgClass` on SVG elements, which we don't use. [1]: https://github.com/angular/angular-cli/blob/b95933a57/packages/angular_devkit/build_angular/src/angular-cli-files/models/es5-polyfills.js PR Close angular#29926
BioPhoton
pushed a commit
to BioPhoton/angular
that referenced
this pull request
May 21, 2019
BioPhoton
pushed a commit
to BioPhoton/angular
that referenced
this pull request
May 21, 2019
…ngular#29926) This commit also changes the `tslint.json` config file to (reasonably closely) match what the cli would generate for a new app. PR Close angular#29926
BioPhoton
pushed a commit
to BioPhoton/angular
that referenced
this pull request
May 21, 2019
…o `ban` (angular#29926) The `no-jasmine-focus` rule has been removed from `vrsource-tslint-rules` [since version 5.8.0][1] (theoretically; practically it remained [until version 5.8.2][2]). This commit removes the non-existent rule (and the obsolete dependency) and uses tslint's `ban` rule instead (as recommended). [1]: vrsource/vrsource-tslint-rules@477f622#diff-04c6e90faac2675aa89e2176d2eec7d8R162 [2]: vrsource/vrsource-tslint-rules#13 (comment) PR Close angular#29926
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrades
@angular/{*, material, cli}to current@nextversions, enables differential loading, enables some more strict TypeScript checks for angular.io and aligns the config files closer to what the cli would generate today.See individual commits for more details.
Blocked on #29976.