Skip to content

Commit

Permalink
build(docs-infra): switch from no-op no-jasmine-focus tslint rule t…
Browse files Browse the repository at this point in the history
…o `ban` (angular#29926)

The `no-jasmine-focus` rule has been removed from
`vrsource-tslint-rules` [since version 5.8.0][1] (theoretically;
practically it remained [until version 5.8.2][2]).

This commit removes the non-existent rule (and the obsolete dependency)
and uses tslint's `ban` rule instead (as recommended).

[1]: vrsource/vrsource-tslint-rules@477f622#diff-04c6e90faac2675aa89e2176d2eec7d8R162
[2]: vrsource/vrsource-tslint-rules#13 (comment)

PR Close angular#29926
  • Loading branch information
gkalpak authored and BioPhoton committed May 21, 2019
1 parent da89bae commit e8abc27
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 7 deletions.
1 change: 0 additions & 1 deletion aio/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,6 @@
"unist-util-source": "^1.0.1",
"unist-util-visit": "^1.1.1",
"unist-util-visit-parents": "^1.1.1",
"vrsource-tslint-rules": "^5.8.2",
"watchr": "^3.0.1",
"xregexp": "^4.0.0",
"yargs": "^7.0.2"
Expand Down
6 changes: 5 additions & 1 deletion aio/tslint.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,11 @@
"rules": {
"array-type": false,
"arrow-parens": false,
"ban": [
true,
{"name": "fdescribe", "message": "Don't keep jasmine focus methods."},
{"name": "fit", "message": "Don't keep jasmine focus methods."}
],
"component-class-suffix": true,
"component-selector": [
true,
Expand Down Expand Up @@ -64,7 +69,6 @@
],
"no-input-rename": true,
"no-inputs-metadata-property": true,
"no-jasmine-focus": true,
"no-output-native": true,
"no-output-on-prefix": true,
"no-output-rename": true,
Expand Down
5 changes: 0 additions & 5 deletions aio/yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -10726,11 +10726,6 @@ void-elements@^2.0.0:
version "2.0.1"
resolved "https://registry.yarnpkg.com/void-elements/-/void-elements-2.0.1.tgz#c066afb582bb1cb4128d60ea92392e94d5e9dbec"

vrsource-tslint-rules@^5.8.2:
version "5.8.3"
resolved "https://registry.yarnpkg.com/vrsource-tslint-rules/-/vrsource-tslint-rules-5.8.3.tgz#b050f25e5967547a3c5e12539b4530d4d3f0d0e0"
integrity sha512-3tYS1zn+d9QtgmQIYmQ9e1i0kipmUjp6cvvYWLC+lZ3z8CQUle7rPKsTFMexOTIVXDpBt9JSJlhDWbwljl3DMQ==

walkdir@^0.0.11:
version "0.0.11"
resolved "https://registry.yarnpkg.com/walkdir/-/walkdir-0.0.11.tgz#a16d025eb931bd03b52f308caed0f40fcebe9532"
Expand Down

0 comments on commit e8abc27

Please sign in to comment.