chore(rxjs): update rxjs to 6.3.2 #12357
Conversation
| @@ -69,7 +69,7 @@ function _visitJsonRecursive<ContextT>( | |||
| ? value as Observable<JsonValue> | |||
| : observableOf(value as JsonValue) | |||
| ).pipe( | |||
| concatMap((value: JsonValue) => { | |||
| concatMap((value): Observable<JsonValue> => { | |||
There was a problem hiding this comment.
That’s not valid TypeScript is it?
There was a problem hiding this comment.
It's missing the input type, or doesn't it need it?
There was a problem hiding this comment.
It's what Rado recommended in these situations. Unfortunately, TS can't infer the return in these cases where there's branching code.
There was a problem hiding this comment.
The input type is inferred.
7ac816c to
8d2bedb
Compare
8d2bedb to
5a87336
Compare
|
@benlesh Thanks for this. However the E2E's will fail due to an issue that we had a chat about some time ago |
| @@ -11,6 +11,7 @@ | |||
| "schematics": "./collection.json", | |||
| "dependencies": { | |||
| "@angular-devkit/core": "0.0.0", | |||
| "@angular-devkit/schematics": "0.0.0" | |||
| "@angular-devkit/schematics": "0.0.0", | |||
| "rxjs": "6.3.2" | |||
There was a problem hiding this comment.
Why does this need to be added here? AFAIK schematics/schematics do not directly depend on rxjs
| @@ -14,6 +14,6 @@ | |||
| ], | |||
| "dependencies": { | |||
| "@angular-devkit/core": "0.0.0", | |||
| "rxjs": "6.2.2" | |||
| "rxjs": "6.3" | |||
There was a problem hiding this comment.
Shouldn't this be 6.3.2 for consistence? As this will be resolved to 6.3.x
|
Closing in favor of #12362 |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Updates CLI to 6.3.2
NOTE: There were two typings that needed to be updated here. One was an honest fix due to improved typings and the limitations of TypeScript, the other is a bit more curious (See the changes to base.ts). There's apparently a problem with spreading an array of operators into
pipe, but only in this case. I'm working on replicating the issue outside of this project, but I haven't been able to do so.