-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge of compose-Latest changes into main #1444
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
riggaroo
commented
Aug 13, 2024
- Including updates such as Shared element transitions
- Migrating Jetsnack to Material3
…ntent as it transitions in size. Clip the background during transition.
Fix overlap of detail text.
…ared-element # Conflicts: # Jetsnack/gradle/libs.versions.toml
Jetsnack sample is using Material 2 instead of Material 3, keeping most of the UI the same as previously. Material 3 is the preferred choice for Material. This pull request migrates to using M3, as well as fixes the filters screen selection to have a shared element transition to show and hide the dialog. https://github.com/user-attachments/assets/0121a41c-2aff-4bb0-abc3-d2075a8f2bd4 It also fixes build issues some machines were experiencing, where there is a mismatch in JVM versions by setting `jvmToolchain` version.
JolandaVerhoef
approved these changes
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.