Jetsnack - Migrate to Material 3 #1437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bentrengrove
approved these changes
Aug 11, 2024
Comment on lines
44
to
60
| // val isDismissed = dismissState.currentValue == SwipeToDismissBoxValue. | ||
| // Returns the swiped value in dp | ||
| val offset = with(LocalDensity.current) { dismissState.offset.value.toDp() } | ||
| // val offset = with(LocalDensity.current) { dismissState.offset.value.toDp() } | ||
|
|
||
| AnimatedVisibility( | ||
| /* AnimatedVisibility( | ||
| modifier = modifier, | ||
| visible = !isDismissed, | ||
| enter = enter, | ||
| exit = exit | ||
| ) {*/ | ||
| SwipeToDismissBox( | ||
| modifier = modifier, | ||
| visible = !isDismissed, | ||
| enter = enter, | ||
| exit = exit | ||
| ) { | ||
| SwipeToDismiss( | ||
| modifier = modifier, | ||
| state = dismissState, | ||
| directions = directions, | ||
| background = { background(offset) }, | ||
| dismissContent = { content(isDismissed) } | ||
| ) | ||
| } | ||
| state = dismissState, | ||
| backgroundContent = { background(/*offset*/) }, | ||
| content = { content(/*isDismissed*/) } | ||
| ) | ||
| /* }*/ |
There was a problem hiding this comment.
Remove the commented out sections?
There was a problem hiding this comment.
Thanks for reminding me about this one, I added it back based on new dismissed state information (progress percentage instead of DP)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jetsnack sample is using Material 2 instead of Material 3, keeping most of the UI the same as previously. Material 3 is the preferred choice for Material.
This pull request migrates to using M3, as well as fixes the filters screen selection to have a shared element transition to show and hide the dialog.
screen-20240806-144504.2.mp4
It also fixes build issues some machines were experiencing, where there is a mismatch in JVM versions by setting
jvmToolchainversion.