Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DockableMenuItem addNotify: Catch All Exceptions and Hide Menu Item #269

Open
andrewauclair opened this issue Jan 27, 2025 · 0 comments
Open

DockableMenuItem addNotify: Catch All Exceptions and Hide Menu Item #269

andrewauclair opened this issue Jan 27, 2025 · 0 comments
Labels
bug Something isn't working fixed Issue has been fixed, pending release.

Comments

@andrewauclair
Copy link
Owner

Currently DockableMenuItem.addNotify only catches DockableRegistrationFailureException and not DockableNotFoundException. Really this should catch all exceptions and hide the menu item.

An error message should also be logged.
@andrewauclair andrewauclair added the bug Something isn't working label Jan 27, 2025
andrewauclair added a commit that referenced this issue Jan 27, 2025
@andrewauclair
Issue #269
258d8da 
DockableMenuItem now catches all exceptions. Issue #272 will make this handling better in the 1.1 release.
andrewauclair added a commit that referenced this issue Jan 27, 2025
@andrewauclair
Issue #269 (#273)
865ddfe 
DockableMenuItem now catches all exceptions. Issue #272 will make this handling better in the 1.1 release.
@andrewauclair andrewauclair added the fixed Issue has been fixed, pending release. label Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working fixed Issue has been fixed, pending release.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@andrewauclair