Issue #269

DockableMenuItem now catches all exceptions. Issue #272 will make this handling better in the 1.1 release.
andrewauclair · Jan 27, 2025 · 258d8da · 258d8da
1 parent 061cb55
commit 258d8da
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/docking-multi-app/src/ModernDocking/app/DockableMenuItem.java b/docking-multi-app/src/ModernDocking/app/DockableMenuItem.java
@@ -103,8 +103,13 @@ public void addNotify() {
 		super.addNotify();
 
 		// update the menu item, it's about to be displayed
-		Dockable dockable = DockingInternal.get(docking).getDockable(persistentIDProvider != null ? persistentIDProvider.get() : persistentID);
-		setSelected(docking.isDocked(dockable));
+		try {
+			Dockable dockable = DockingInternal.get(docking).getDockable(persistentIDProvider != null ? persistentIDProvider.get() : persistentID);
+			setSelected(docking.isDocked(dockable));
+		}
+		catch (Exception ignored) {
+			setVisible(false);
+		}
 	}
 
 	@Override

diff --git a/docking-single-app/src/ModernDocking/app/DockableMenuItem.java b/docking-single-app/src/ModernDocking/app/DockableMenuItem.java
@@ -90,7 +90,7 @@ public void addNotify() {
 			Dockable dockable = DockingInternal.get(Docking.getSingleInstance()).getDockable(persistentIDProvider != null ? persistentIDProvider.get() : persistentID);
 			setSelected(Docking.isDocked(dockable));
 		}
-		catch (DockableRegistrationFailureException ignored) {
+		catch (Exception ignored) {
 			setVisible(false);
 		}
 	}