Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust Checkout Agreements Block #5

Closed
islandskater43 opened this issue Nov 15, 2016 · 4 comments
Closed

Adjust Checkout Agreements Block #5

islandskater43 opened this issue Nov 15, 2016 · 4 comments
Labels
ack enhancement needs investigation
Milestone
1.0.10

Comments

@islandskater43
Copy link
Contributor

In the file vendor/amazon/module-login-and-pay/src/Payment/view/frontend/web/template/payment/amazon-payment-widget.html you have this div:

<div class="checkout-agreements-block"></div>

This is what other payment methods have that pulls in the Terms and Agreements checkbox.

  <div class="checkout-agreements-block">
       <!-- ko foreach: $parent.getRegion('before-place-order') -->
           <!-- ko template: getTemplate() --><!-- /ko -->
       <!--/ko-->
   </div>

Can this be updated in this extension?
@danielneu
Copy link
Contributor

@islandskater43 I can ammend the code and test this.
What exactly would be the difference I should see after implementing this?

@danielneu danielneu added this to the 1.0.8 milestone Nov 30, 2016
@Silarn Silarn mentioned this issue Dec 1, 2016
Merged
@Silarn
Copy link
Contributor

Silarn commented Dec 1, 2016

To answer your question, if you've enabled terms and conditions in checkout, you're supposed to see a check box with a link to view the terms in order to agree. When this is enabled, orders will not validate unless the agreement is agreed to.

@danielneu danielneu modified the milestones: 1.0.9, 1.0.8 Dec 8, 2016
@Silarn
Copy link
Contributor

Silarn commented Jan 13, 2017

What's the status of this? My PR has been working for us without any problems. I'm hoping to return to using the core Amazon code sooner or later.

@danielneu danielneu added the ack label Jan 17, 2017
@danielneu
Copy link
Contributor

solved by #11

@salikahmed salikahmed mentioned this issue Oct 11, 2017
Closed
lemked pushed a commit that referenced this issue Aug 27, 2018
@MicheleBeargroup
Merge pull request #5 from BearGroup/support-issue-AP-414
227828e 
Update - removed all references to adding history/status messages to …
@perfpcs perfpcs mentioned this issue Aug 6, 2019
Closed
@anant-svc anant-svc mentioned this issue Oct 14, 2021
Closed
@ccsliinc ccsliinc mentioned this issue May 3, 2022
Closed
zichicc pushed a commit that referenced this issue Jun 6, 2022
@ccsliinc @sgabhart22
Undefined index 'charge_permission_id'
02b491d 
Async Error log was full of these.  

amazonAsyncIpnLogger.ERROR: Exception: Notice: Undefined index: charge_permission_id in /var/www/shop/prod/vendor/amzn/amazon-pay-magento-2-module/Model/AsyncManagement/Charge.php on line 213 in /var/www/shop/prod/vendor/magento/framework/App/ErrorHandler.php:61
Stack trace:
#0 /var/www/shop/prod/vendor/amzn/amazon-pay-magento-2-module/Model/AsyncManagement/Charge.php(213): Magento\Framework\App\ErrorHandler->handler()
#1 /var/www/shop/prod/vendor/amzn/amazon-pay-magento-2-module/Model/AsyncManagement/Charge.php(167): Amazon\Pay\Model\AsyncManagement\Charge->decline()
#2 /var/www/shop/prod/vendor/amzn/amazon-pay-magento-2-module/Model/AsyncUpdater.php(79): Amazon\Pay\Model\AsyncManagement\Charge->processStateChange()
#3 /var/www/shop/prod/vendor/amzn/amazon-pay-magento-2-module/Cron/ProcessAsync.php(71): Amazon\Pay\Model\AsyncUpdater->processPending()
#4 [internal function]: Amazon\Pay\Cron\ProcessAsync->execute()
#5 /var/www/shop/prod/vendor/magento/module-cron/Observer/ProcessCronQueueObserver.php(368): call_user_func_array()
#6 /var/www/shop/prod/vendor/magento/module-cron/Observer/ProcessCronQueueObserver.php(879): Magento\Cron\Observer\ProcessCronQueueObserver->_runJob()
#7 /var/www/shop/prod/vendor/magento/module-cron/Observer/ProcessCronQueueObserver.php(840): Magento\Cron\Observer\ProcessCronQueueObserver->tryRunJob()
#8 /var/www/shop/prod/vendor/magento/module-cron/Observer/ProcessCronQueueObserver.php(280): Magento\Cron\Observer\ProcessCronQueueObserver->processPendingJobs()
#9 /var/www/shop/prod/vendor/magento/framework/Event/Invoker/InvokerDefault.php(88): Magento\Cron\Observer\ProcessCronQueueObserver->execute()
#10 /var/www/shop/prod/vendor/magento/framework/Event/Invoker/InvokerDefault.php(74): Magento\Framework\Event\Invoker\InvokerDefault->_callObserverMethod()
#11 /var/www/shop/prod/vendor/magento/framework/Event/Manager.php(66): Magento\Framework\Event\Invoker\InvokerDefault->dispatch()
#12 /var/www/shop/prod/generated/code/Magento/Framework/Event/Manager/Proxy.php(95): Magento\Framework\Event\Manager->dispatch()
#13 /var/www/shop/prod/vendor/magento/framework/App/Cron.php(86): Magento\Framework\Event\Manager\Proxy->dispatch()
#14 /var/www/shop/prod/vendor/magento/module-cron/Console/Command/CronCommand.php(117): Magento\Framework\App\Cron->launch()
#15 /var/www/shop/prod/vendor/symfony/console/Command/Command.php(255): Magento\Cron\Console\Command\CronCommand->execute()
#16 /var/www/shop/prod/vendor/magento/framework/Interception/Interceptor.php(58): Symfony\Component\Console\Command\Command->run()
#17 /var/www/shop/prod/vendor/magento/framework/Interception/Interceptor.php(138): Magento\Cron\Console\Command\CronCommand\Interceptor->___callParent()
#18 /var/www/shop/prod/vendor/magento/framework/Interception/Interceptor.php(153): Magento\Cron\Console\Command\CronCommand\Interceptor->Magento\Framework\Interception\{closure}()
#19 /var/www/shop/prod/generated/code/Magento/Cron/Console/Command/CronCommand/Interceptor.php(77): Magento\Cron\Console\Command\CronCommand\Interceptor->___callPlugins()
#20 /var/www/shop/prod/vendor/symfony/console/Application.php(1009): Magento\Cron\Console\Command\CronCommand\Interceptor->run()
#21 /var/www/shop/prod/vendor/symfony/console/Application.php(273): Symfony\Component\Console\Application->doRunCommand()
#22 /var/www/shop/prod/vendor/magento/framework/Console/Cli.php(115): Symfony\Component\Console\Application->doRun()
#23 /var/www/shop/prod/vendor/symfony/console/Application.php(149): Magento\Framework\Console\Cli->doRun()
#24 /var/www/shop/prod/bin/magento(23): Symfony\Component\Console\Application->run()
#25 {main} [] []
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ack enhancement needs investigation
Projects
None yet
Milestone
1.0.10
Development

No branches or pull requests
3 participants
@Silarn @islandskater43 @danielneu