Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AMP Stories - Minor recommended interface improvements/fixes #1686

Closed
4 tasks
alcurrie opened this issue Dec 2, 2018 · 5 comments
Closed
4 tasks

AMP Stories - Minor recommended interface improvements/fixes #1686

alcurrie opened this issue Dec 2, 2018 · 5 comments
Milestone

Comments

@alcurrie
Copy link

alcurrie commented Dec 2, 2018

Based on QA review here are some outstanding minor recommended interface improvements/fixes to make the AMP Stories interface easier for users:

Related to: #1532

@alcurrie
Copy link
Author

alcurrie commented Dec 3, 2018

@mehigh @miina - the above are recommended updates coming out of QA. I believe @cathibosco will likely have a few more coming out of her work on the demo. I think it makes sense to track them in one place. None of the issues above are blockers, particularly if they are blocked by Gutenberg or would be a big lift, but if they are relatively minor fixes, they would be improvements to the user interface.

@alcurrie alcurrie assigned mehigh and miina and unassigned alcurrie Dec 3, 2018
@miina
Copy link
Contributor

miina commented Dec 3, 2018

Thank you for QA-ing the tickets, @alcurrie.

1: For doing that we would need to rename the block name -- then it would appear as "Story Page" everywhere. Initially it was "AMP Story Page" but that was specifically requested to be removed from all the blocks and then it was left just with "Page". I'm fine either way but this is probably something that would be good to confirm since the names of the blocks was something under discussion previously.
2: Unfortunately that doesn't seem to be possible at this moment -- the ghosted page is basically restyled from the default Inserter (the Plus icon) -- that's something that is displayed according to the default behavior of Gutenberg and not actually added by us at all. Mike restyled it but didn't add it himself. One option would be to rework the current solution entirely and instead make the ghosted page part of the Page block -- this way we would have more control over it but not sure if that would be the best option and also not sure if it would make sense in terms of time at this moment.

@miina miina assigned alcurrie and unassigned mehigh and miina Dec 12, 2018
@miina
Copy link
Contributor

miina commented Dec 12, 2018

@alcurrie As talked this ticket can be removed to backlog for future iteration.

@alcurrie
Copy link
Author

Thanks @miina - I've moved this to the backlog to be looked at for a future iteration for AMP stories.

@alcurrie alcurrie removed their assignment Dec 12, 2018
@alcurrie alcurrie added this to the v1.1 milestone Dec 12, 2018
@westonruter westonruter removed this from the v1.1 milestone Mar 6, 2019
@westonruter
Copy link
Member

I believe this is obsolete now.

@westonruter westonruter added this to the v1.2 milestone May 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants