-
Notifications
You must be signed in to change notification settings - Fork 384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve the flow for adding new page blocks below existing stories #1532
Comments
@westonruter Thanks for the call out on the plus already being available. I've updated AC1 to take into account that this task maybe partially done, though may need some additional improvements to meet the overall 'goal' in this ticket. @jwold - Based on Weston's screen shot, this looks like we'll need to take this into account when making this interface change to make adding pages easier. |
We could get inspired from the standard photo editors new layer icon:
This provides more information than a regular plus sign. The plus at the bottom would make sense to add another page in the story, the layers was the only one I felt needed an improvement. |
Dev is currently blocked by design as we need a UX suggestion for what it will look like. |
@miina howdy! @alcurrie and I spent a bit of time going over this, and I'd love your feedback, as well as letting me know if you need anything more. Here is the graphic with suggested changes: And here is the Figma file: https://www.figma.com/file/fJFUvAKJGNjH2wCzgj5ke4PF/Untitled?node-id=1%3A127 Should I get you the new icons as SVG or PNG? Thank you! |
I think the page icon works, currently I can’t think of a way to improve it. Half of the problem is knowing what each inserter does! That one adds a page - no question. It is good for now |
Thanks for the feedback @cathibosco, I'll go ahead and remove the UX feedback label now @alcurrie as I think this is dev ready. |
@jwold and @cathibosco - I've pulled this back to definition, as based on further discussion on related issues, the interface sketch here, is no longer up to date. |
@cathibosco can you take a look at this with the view to integrating it into the overall interface updates/changes. cc. @jwold |
Got it added now - thank you @alcurrie |
I've made a first pass at converting the block-appender inserter into the "ghosted" page, hiding the other inserter/shortcut icons in the process. PR for review or further functionality as needed: #1632 |
@bluestormcreative This isn't ready for prime time. This shouldn't remove the side adder - http://cloud.urldocs.com/a4d53dd19dbf Instead we need to figure out a way to turn this normally hidden + button at the bottom into a page adder: |
Actually the hiding of those elements I did undo quickly.. and the reason the add ghosted page went berserk is due to a Gutenberg update. You were seeing a different "+" structure than I'm seeing, hence the selectors didn't play along well. |
How this looks now: The small page icons in the side-nav is updated now |
This handles the first item in AC1 and AC3. AC2 - Consider not adding the extra page numbering AC 3: Update the page icon in the block navigation - this is completed as well |
Fixed via merging #1632 |
Confirmed that add a new page interface, with the new 'ghosted' page interface, and the update of the icon for pages in the block navigation elsewhere in the interface. https://cl.ly/24d18e6425f9 See #1686 - for related minor interface improvements/fixes |
As a AMP story author, I want a better user flow for adding new page blocks below existing stories, so I'm able to easily understand how to add new pages to my AMP story
- [x] Display ghosted Story page by default on a new AMP story or below the last AMP story page as shown in this mockup: https://cl.ly/4840a3512886
- [x] On tap/click anywhere on the 'ghosted story' page a new story page is created
- [x] When a new story page is created, the block navigation with the (+) Add Layer icon above the Block Navigation (heading) and the Story page top level on the block navigation selected
Add page number to the AMP stories page interface to represent what story page the user currently editing. (Based on the new, easier story page/layer manipulation Improve Layer Manipulation #1564 consider not numbering story pages in order to not cause confusion when pages are 'reordered'.)The text was updated successfully, but these errors were encountered: