fix(server_openvr): Calculate velocities for skeleton-based controllers #2416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zmerp
requested changes
Sep 20, 2024
zmerp
requested changes
Sep 20, 2024
|
All clear, thanks |
zmerp
approved these changes
Sep 20, 2024
zmerp
pushed a commit
that referenced
this pull request
Sep 20, 2024
…rs (#2416) * Calculate velocities for skeleton-based controllers * format * no chrono, no verbs * hopefully last nits
Merged
zmerp
pushed a commit
that referenced
this pull request
Sep 21, 2024
…rs (#2416) * Calculate velocities for skeleton-based controllers * format * no chrono, no verbs * hopefully last nits
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calculates the hand skeleton velocity based on the controller's last sent
m_pose; Adds an additionaltargetTimestampNsargument to the controller'sonPoseUpdate, as well as an additional stored timestampm_poseTargetTimestampNsfor that pose to allow calculating the velocity of the controller. This calculation is only performed ifcontrollerMotionis missing but the skeleton is present.Fixes the waving exercise in Aperture Hand Lab, and probably throwing and other interactions in other titles.