This repository has been archived by the owner on Sep 29, 2023. It is now read-only.
Consolidated v4 fixes #9
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeffreyFG
commented
Sep 12, 2023
- Small correction to the comment on which type of dataset is the default option. Perviously the comment stated that the default dataset type was raw. The dataset type is important because based on that the client would try to post a the scicat server with a different route this has been changed but the comment needed to be updated to reflect this change.
- archiveId is no longer part of the OrigDatablock but chkAlg is.
… ESS-adding-in-house-functionalities
…com/SciCatProject/pyscicat into ESS-adding-in-house-functionalities
…n of documentation, updated example. Added packages in requirements to requirements-dev.
…house-functionalities Ess adding in house functionalities
…ommit remove pre-commit
…ignored by the current actions workflows.
…from the setup config.
… is not part of package
…-datasets V4 datasets
…tup-cfg-hotfix removing quotation marks that causes pypi to fail
Support newer versions of pydantic
…upport the current routes available on the newest version(v4.x) of the scicat backend. It also makes a small change to the OrigDatablock to support what is required in the new backend.
ownerGroup will now longer be required by the pydantic model and because the backend will not accept it
|
Can you please rebase so that the PR contains just your commits? Something like this: https://stackoverflow.com/a/45286781 Thanks! |
|
Oh I see. I should archive this repo. My apologies. We moved this to https://github.com/scicatproject/pyscicat |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.