Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove pre-commit #15

Merged

Conversation

dylanmcreynolds
Copy link
Member

Pre-commit is great in theory and it's fantastic to be able to enforce the use of black to proivde consistent formatting.

But it's buggy and hard to use.

I'm ripping it out. We still call flake8 in the github action, but no longer use pre-commit.

@dylanmcreynolds dylanmcreynolds merged commit 0ff79d7 into SciCatProject:main Apr 27, 2022
@dylanmcreynolds dylanmcreynolds mentioned this pull request Apr 27, 2022
@jl-wynen
Copy link
Collaborator

If you still want to enforce formatting, you can set up an action to format the code and auto commit the result. I can point you to our setup if you're interested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants