Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run on Node20( lts) #4812

Merged
merged 1 commit into from
Jan 26, 2024
Merged

Run on Node20( lts) #4812

merged 1 commit into from
Jan 26, 2024

Conversation

kr8n3r
Copy link
Contributor

@kr8n3r kr8n3r commented Jan 17, 2024

What

Changes required to make admin run on node 20

  • Specify package.json engine versions
  • Update .nvmrc to specify latest lts version
  • Update test due to a change in Node
  • Tell CI to run on node 20

Why

Node 18 in now in maintenance mode and will be EOL April 2025. Time to get on the new long-term support version

How to review

deploy to dev env or run locally

Who can review

anyone


🚨⚠️ Please do not merge this pull request via the GitHub UI ⚠️🚨

@kr8n3r kr8n3r force-pushed the node-lts branch 2 times, most recently from c363526 to 26c3a4c Compare January 18, 2024 08:19
@kr8n3r kr8n3r changed the title Node 20 LTS Run on Node20( lts) Jan 19, 2024
@kr8n3r kr8n3r marked this pull request as ready for review January 24, 2024 12:35
Copy link

@corlettb corlettb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deployed to dev03.
Clicked around to test functionality.
Verified it is on node v20.10.0.
All good.

Specify package.json engine versions
Update .nvmrc to specify latest lts version
Update test due to an change in Node
Tell CI to run on node 20
@kr8n3r kr8n3r merged commit 19cfda5 into main Jan 26, 2024
2 checks passed
@kr8n3r kr8n3r deleted the node-lts branch January 26, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants