Skip to content

Commit

Permalink
Run admin on Node20 LTS
Browse files Browse the repository at this point in the history
Specify package.json engine versions
Update .nvmrc to specify latest lts version
Update test due to an change in Node
Tell CI to run on node 20
  • Loading branch information
kr8n3r committed Jan 18, 2024
1 parent df238c4 commit 26c3a4c
Show file tree
Hide file tree
Showing 5 changed files with 9 additions and 7 deletions.
2 changes: 1 addition & 1 deletion .nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
lts/Hydrogen
lts/Iron
2 changes: 1 addition & 1 deletion ci/integration.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ image_resource:
type: docker-image
source:
repository: node
tag: 18-alpine
tag: 20-alpine
inputs:
- name: repo
run:
Expand Down
4 changes: 2 additions & 2 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -155,8 +155,8 @@
}
},
"engines": {
"node": "18.x.x",
"npm": ">=8.x.x"
"node": "20.x.x",
"npm": ">=10.x.x"
},
"jest": {
"testEnvironment": "node",
Expand Down
4 changes: 3 additions & 1 deletion src/server/server.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,9 @@ describe('server test suite', () => {
request(`http://localhost:${port}`)
.get('/')
.timeout(500),
).rejects.toThrow(/ECONNREFUSED/);
).rejects.toMatchObject ({
code: 'ECONNREFUSED',
});
});

it('should replace the handler when updated', async () => {
Expand Down

0 comments on commit 26c3a4c

Please sign in to comment.