Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump express-validator from 6.14.3 to 6.15.0 #3304

Merged
merged 2 commits into from
Feb 21, 2023
Merged

Bump express-validator from 6.14.3 to 6.15.0 #3304

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0bb5810
Bump express-validator from 6.14.3 to 6.15.0
dependabot[bot] Feb 17, 2023
e8c92e9
Ensure workspace `node_modules` are cached
colinrotherham Feb 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion .github/workflows/actions/install-node/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,11 @@ runs:
with:
# Restore `node_modules` cache (unless packages change)
key: npm-install-cache-${{ runner.os }}-${{ hashFiles('package-lock.json', '**/package.json') }}
path: node_modules
path: |
node_modules
app/node_modules
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should ensure any (potential) workspace node_modules are also cached

Due to symbolic links created by npm link or npm workspaces we can't use:

path: |
  **/node_modules

Otherwise we could match and cache "packages of linked packages" one day:

app/node_modules/govuk-frontend/node_modules/** #symlink-1
node_modules/govuk-frontend/node_modules/** #symlink-1
package/node_modules/** #source

docs/examples/*/node_modules
package/node_modules

- name: Setup Node.js
uses: ./.github/workflows/actions/setup-node
Expand Down
2 changes: 1 addition & 1 deletion app/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
"dependencies": {
"cookie-parser": "^1.4.6",
"express": "^4.18.2",
"express-validator": "^6.14.3",
"express-validator": "^6.15.0",
"front-matter": "^4.0.2",
"glob": "^8.1.0",
"govuk_frontend_toolkit": "^9.0.1",
Expand Down
74 changes: 38 additions & 36 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.