Bump express-validator from 6.14.3 to 6.15.0 #3304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [express-validator](https://github.com/express-validator/express-validator) from 6.14.3 to 6.15.0. - [Release notes](https://github.com/express-validator/express-validator/releases) - [Commits](express-validator/express-validator@v6.14.3...v6.15.0) --- updated-dependencies: - dependency-name: express-validator dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
|
Likely due to npm package incompatibilities, this update can't be hoisted to Checks have failed since we cache 1.
|
To avoid package incompatibilities, npm can choose _not_ to hoist to the top-level `node_modules` directory We have to avoid matching `**/node_modules` otherwise nested “packages of packages” will be cached from linked workspaces etc
| path: node_modules | ||
| path: | | ||
| node_modules | ||
| app/node_modules |
There was a problem hiding this comment.
We should ensure any (potential) workspace node_modules are also cached
Due to symbolic links created by npm link or npm workspaces we can't use:
path: |
**/node_modulesOtherwise we could match and cache "packages of linked packages" one day:
app/node_modules/govuk-frontend/node_modules/** #symlink-1
node_modules/govuk-frontend/node_modules/** #symlink-1
package/node_modules/** #source
colinrotherham
approved these changes
Feb 17, 2023
romaricpascal
approved these changes
Feb 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps express-validator from 6.14.3 to 6.15.0.
Release notes
Sourced from express-validator's releases.
Commits
5202222feat: update to support validator 13.9.0 (#1212)10ecbd1deps: bump http-cache-semantics from 4.1.0 to 4.1.1 (#1210)5eedc19deps: bump eta from 1.12.3 to 2.0.0 (#1211)067e908deps: upgrade typescript to v4.3.59d05a40deps: bump ua-parser-js from 0.7.32 to 0.7.33 (#1208)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)