Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove sass lint #1902

Merged
merged 6 commits into from
Sep 14, 2020
Merged

Remove sass lint #1902

merged 6 commits into from
Sep 14, 2020

Conversation

vanitabarrett
Copy link
Contributor

@vanitabarrett vanitabarrett commented Aug 6, 2020 •
edited
Loading

Dependant on #1875
Needs to be rebased against master once that's merged

Commits to review:

Closes #1898

@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-1902 August 6, 2020 14:40 Inactive
m-green
m-green reviewed Aug 19, 2020
View reviewed changes
Copy link
Contributor

@m-green m-green left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs commit looks good to me! Just a couple of style suggestions and fixes.

docs/contributing/coding-standards/css.md Outdated Show resolved Hide resolved
docs/contributing/coding-standards/css.md Outdated Show resolved Hide resolved
docs/contributing/coding-standards/css.md Outdated Show resolved Hide resolved
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-1902 August 21, 2020 13:00 Inactive
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-1902 August 21, 2020 13:01 Inactive
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-1902 August 21, 2020 13:22 Inactive
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-1902 August 21, 2020 13:52 Inactive
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-1902 August 21, 2020 13:54 Inactive
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-1902 August 21, 2020 14:01 Inactive
@vanitabarrett vanitabarrett marked this pull request as ready for review August 21, 2020 14:03
@vanitabarrett vanitabarrett changed the title [WIP] Remove sass lint Remove sass lint Aug 21, 2020
36degrees
36degrees reviewed Aug 24, 2020
View reviewed changes
docs/contributing/tasks.md Outdated Show resolved Hide resolved
docs/contributing/coding-standards/css.md Outdated Show resolved Hide resolved
src/govuk/helpers/_font-faces.scss Outdated Show resolved Hide resolved
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-1902 August 25, 2020 10:52 Inactive
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-1902 August 25, 2020 10:59 Inactive
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-1902 August 25, 2020 12:48 Inactive
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-1902 August 25, 2020 13:29 Inactive
@vanitabarrett
Copy link
Contributor Author

@36degrees Added a test for the copyright notice 🙂

@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-1902 August 26, 2020 08:51 Inactive
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-1902 August 26, 2020 12:50 Inactive
36degrees
36degrees approved these changes Aug 26, 2020
View reviewed changes
Copy link
Contributor

@36degrees 36degrees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've only reviewed 529f2b9 through d0392d8, as the other commits have been reviewed in #1875.

@kevindew kevindew mentioned this pull request Sep 14, 2020
Merged
Vanita Barrett added 6 commits September 14, 2020 14:25
Remove sass lint
f5b4ce4
Remove outdated docs on gulp:lint task
22c814e 
Looks like this doesn't exist in GOVUK Frontend at the moment, so removing this even though it's not directly related to this change.
Remove old sass-lint disable rules
df45117
Update docs
316b429
Tweak font-faces file to appease linter
6c92543
Add test for copyright notice
0bd7651
@vanitabarrett vanitabarrett merged commit cf5be78 into master Sep 14, 2020
@vanitabarrett vanitabarrett deleted the remove-sass-lint branch September 14, 2020 13:42
@lfdebrux lfdebrux mentioned this pull request May 12, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m-green m-green m-green left review comments

@36degrees 36degrees 36degrees approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove sass-lint while switching to stylelint
4 participants
@vanitabarrett @36degrees @m-green @govuk-design-system-ci