Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove sass-lint while switching to stylelint #1898

Closed
vanitabarrett opened this issue Aug 4, 2020 · 3 comments · Fixed by #1902
Closed

Remove sass-lint while switching to stylelint #1898

vanitabarrett opened this issue Aug 4, 2020 · 3 comments · Fixed by #1902
Assignees

Comments

@vanitabarrett
Copy link
Contributor

What

This PR introduces stylelint alongside our existing linting (using sass-lint). We need to remove sass-lint, so we're only using stylelint.

Why

GOVUK needs to move away from scss-lint as it's blocking their upgrade from Ruby SASS to Sassc. They have chosen stylelint and have raised a PR against GOVUK Frontend to demonstrate how we may switch to stylelint to match. This will also be shared with the frontend community so we can aim for consistency across GDS.

@36degrees 36degrees mentioned this issue Aug 4, 2020
5 tasks
@vanitabarrett vanitabarrett changed the title Remove sass-lint while switching to style-lint Remove sass-lint while switching to stylelint Aug 4, 2020
@vanitabarrett vanitabarrett self-assigned this Aug 5, 2020
@vanitabarrett
Copy link
Contributor Author

WIP PR raised, but waiting to see if anything new comes out of #1897

@m-green
Copy link
Contributor

m-green commented Aug 11, 2020

Hi @vanitabarrett - could you let me know when you start work on this so we can take a look at documentation changes in plenty of time?

@vanitabarrett
Copy link
Contributor Author

@m-green Yep, will do! Waiting for #1897 , and then will ping you once we've made some decisions on that 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging a pull request may close this issue.

3 participants