-
Notifications
You must be signed in to change notification settings - Fork 338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SVGImage does not support src
attribute
#1688
Comments
Heya :) This is done intentionally so that the header will display the fallback only in older browsers, it is documented in our known warnings: Thank you for checking with us but I will close this as there's no action to take at this time. |
The IE developer tools might show it requesting the fallback, but it should abort almost immediately before downloading anything. If you're seeing both requests actually completing in any browser, please let us know which browser / OS you're seeing this in so we can investigate. Thanks |
@paroxp I'm not seeing that in Chrome… is that using the exact same markup / styles as in GOV.UK Frontend? |
No no, as I've mentioned in the initial issue:
sorry for the confusion. |
We need to have a reproducible way of handling React elements through out the system. This is required to handle things like GOV.UK Frontend, Page Titles, global CSRF tokens and similar shared elements. We're also Reactifying the first piece of the system. We have to sadly override some of the JSX interfaces globally, due to some HTML backwards supportability. [See here][1] [1]: alphagov/govuk-frontend#1688
We need to have a reproducible way of handling React elements through out the system. This is required to handle things like GOV.UK Frontend, Page Titles, global CSRF tokens and similar shared elements. We're also Reactifying the first piece of the system. We have to sadly override some of the JSX interfaces globally, due to some HTML backwards supportability. [See here][1] [1]: alphagov/govuk-frontend#1688
We need to have a reproducible way of handling React elements through out the system. This is required to handle things like GOV.UK Frontend, Page Titles, global CSRF tokens and similar shared elements. We're also Reactifying the first piece of the system. We have to sadly override some of the JSX interfaces globally, due to some HTML backwards supportability. [See here][1] [1]: alphagov/govuk-frontend#1688
We need to have a reproducible way of handling React elements through out the system. This is required to handle things like GOV.UK Frontend, Page Titles, global CSRF tokens and similar shared elements. We're also Reactifying the first piece of the system. We have to sadly override some of the JSX interfaces globally, due to some HTML backwards supportability. [See here][1] [1]: alphagov/govuk-frontend#1688
We need to have a reproducible way of handling React elements through out the system. This is required to handle things like GOV.UK Frontend, Page Titles, global CSRF tokens and similar shared elements. We're also Reactifying the first piece of the system. We have to sadly override some of the JSX interfaces globally, due to some HTML backwards supportability. [See here][1] [1]: alphagov/govuk-frontend#1688
What
You seem to be using SVGs, with a fallback image defined as
src
attribute of animage
tag. This appears not to be a thing in accordance to the API reference.I'm not certain if this causes any issues. I do know, that using the
href
tag that is in fact documented, will break the design by loading both svg and fallback image.Stumbled upon this whilst writing some syntax in TypeScript'ed React.
The text was updated successfully, but these errors were encountered: