-
Notifications
You must be signed in to change notification settings - Fork 338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SVG Fallback logo #2182
Comments
Hi @Dawdre 👋 We add the Are you able to expand on the issue that you're experiencing with this? |
Thanks for you swift response. Less of an issue on our end and more of a question regarding the use for it. I am assuming the fall back PNG image is only for IE8? Therefore IE8 would always request it. My tests have shown me that removing Freemarker template example https://developer.mozilla.org/en-US/docs/Web/SVG/Element/image shows the Additionally I am somewhat confused on the need for https://stackoverflow.com/questions/5775469/whats-the-valid-way-to-include-an-image-with-no-src#answer-53365710 (my confusion is off the assumption that As My testing may not able to replicate what you were able to so happy to close this with some clarification on the below. Furthermore a question about browser support. What is the official stance on IE8 generally? https://github.com/alphagov/govuk-frontend here states "GOVUK Frontend supports: Internet Explorer 8, 9 and 10, although components may not look perfect". https://www.gov.uk/service-manual/technology/designing-for-different-browsers-and-devices shows IE11 compliant. Our application's browser support are mirroring the information in that table - IE11+. I appreciate it does go further in defining what "compliant" means and GOVUK Frontend needs to make sure the majority can access the information they need. Thus building for IE8+. Does this mean our markup will contain markup only written for IE8? As consumers of GOVUK Frontend, I am sure you can appreciate we want to remain as aligned with your HTML markup (and code in general) as we can. Divergences does make maintenance tricky. A fairly minor issue certainly but as a consumer who copies your HTML almost verbatim into our environment. I figured I would ask the question. |
Yes, that’s expected behaviour as the GOV.UK implementation doesn’t currently use the design system component - this is something the GOV.UK team are working on at the moment. In terms of use of
As you noticed, GOV.UK Frontend supports IE 8, 9 and 10 whereas the service manual only specifies IE11+. Generally, the service manual is the minimum level of support that we’d expect from services, but we recommend services look into the browsers used to access their services and use that to inform their support levels too. We know there are services with a higher percentage of traffic from older versions of IE and GOV.UK Frontend needs to work for these services too, so we aim for a higher level of support than specified in the service manual. I'm going to close this issue for now as don’t think there’s anything for us to do here at the moment, but please feel free to comment on this issue if you have any follow-up questions and we will get back to you. |
Related component
https://design-system.service.gov.uk/components/header/
<image src="/assets/images/govuk-logotype-crown.png" xlink:href="data:," display="none" class="govuk-header__logotype-crown-fallback-image" width="36" height="32"></image>
Context
Our application uses more than 1 header logo and some image 404s lead to an investigation on the need for fallback PNGs due to our browser support being IE11+ (SVG support is very wide). We would like to keep parity with govuk-frontend as much as possible so will be introducing a fix of our own.
It did raise a question on the
image
tag and more specificallyxlink:href
attribute shown above. It appears to be deprecated andhref
being the recommended method. https://developer.mozilla.org/en-US/docs/Web/SVG/Attribute/xlink:hrefIs there a fix in mind for this?
Has alternative logo support for the header component been discussed? A tricky issue certainly but possibly some further documentation for when you are changing the default logo.
Additional information (if applicable)
We have also noticed this feature working well on the GOV.UK Design System site (falling back to an img) but on GOV.UK (The logo does not show at all. I assume the headers are completely different markup).
The text was updated successfully, but these errors were encountered: