-
Notifications
You must be signed in to change notification settings - Fork 339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fail the build if compilation fails with any of our supported Sass compilers #1684
Comments
From my investigation there is very minor differences in the output between compilers. We will document the minimum we expect our users to require in our install documentation. To test the minimum if our build pipeline I think is not worth the complexity at this point. Ruby sass would require us to add Ruby infrastructure to the project, and it is a deprecated project. The minimum version of libsass we'd need to run an older version of Node.js The only thing we could consider is testing dart-sass, but I think it's probably worth relying on support issues instead given what I've seen. |
This is what I had in mind for testing different Sass compilers: https://github.com/alphagov/govuk-frontend/compare/test-sass-compilers?expand=1 Which results in a build output like this: I believe we could set the additional two tasks up as separate jobs rather than separate stages, which would allow them to run in parallel rather than in series. I'm just trying to get my head around the syntax required to do that. Is that less complex than you'd been imagining? |
Being able to conditionally specify node versions with Travis simplifies most of my worries. Would be good to keep any eye on the additional time it might take, or if it could create a bottleneck. |
Compile the GOV.UK Frontend Sass using the minimum version of each of the Sass compilers that we support: - LibSass v3.3.0 - Dart Sass v1.0.0 - Ruby Sass v3.4.0 (deprecated; not recommended) Fail the build if it fails to compile using any one of them. We're doing this so that we have the confidence to ship releases whilst knowing that they should work with any of the Sass compilers that we support. Closes #1684
Compile the GOV.UK Frontend Sass using the minimum version of each of the Sass compilers that we support: - LibSass v3.3.0 - Dart Sass v1.0.0 - Ruby Sass v3.4.0 (deprecated; not recommended) Fail the build if it fails to compile using any one of them. We're doing this so that we have the confidence to ship releases whilst knowing that they should work with any of the Sass compilers that we support. This also removes a before_deploy step (because we no longer have a deploy step) and the sudo key as according to Travis' config linter it has no effect any more. Closes #1684
Compile the GOV.UK Frontend Sass using the minimum version of each of the Sass compilers that we support: - LibSass v3.3.0 - Dart Sass v1.0.0 - Ruby Sass v3.4.0 (deprecated; not recommended) Fail the build if it fails to compile using any one of them. We're doing this so that we have the confidence to ship releases whilst knowing that they should work with any of the Sass compilers that we support. This also removes a before_deploy step (because we no longer have a deploy step) and the sudo key as according to Travis' config linter it has no effect any more. Closes #1684
What
Compile the GOV.UK Frontend Sass using the minimum version of each of the Sass compilers that we support.
Fail the build if it fails to compile using any one of them.
Why
So that we have the confidence to ship releases whilst knowing that they should work with any of the Sass compilers that we support
Questions / prompts
Dependencies
The text was updated successfully, but these errors were encountered: