Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve support for different Sass compilers #1685

Closed
3 tasks done
36degrees opened this issue Dec 23, 2019 · 0 comments
Closed
3 tasks done

Improve support for different Sass compilers #1685

36degrees opened this issue Dec 23, 2019 · 0 comments
Labels
epic Epics are used in planning project boards to group related stories sass / css

Comments

@36degrees
Copy link
Contributor

36degrees commented Dec 23, 2019

GOV.UK have flagged that our Sass is slow to compile. Although this mostly affects ruby-sass, which is deprecated, it has a noticeable effect in other compilers too.

Doing this should also help improve the workflow in the review app as it’ll make reloads faster.
We might also want to consider finding a way to benchmark / set up a budget for this so that we don’t accidentally make it slower again in the future.

This will probably involve making breaking changes, so we should plan it as part of GOV.UK Frontend 4.0.

Related, we should consider setting up tests that make sure that GOV.UK Frontend works with the various different Sass compilers, and ideally define the minimum versions that we expect GOV.UK Frontend to support, and understand what features we can therefore use.

Stories

@36degrees 36degrees added the epic Epics are used in planning project boards to group related stories label Dec 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
epic Epics are used in planning project boards to group related stories sass / css
Projects
None yet
Development

No branches or pull requests

2 participants