Skip to content

Commit

Permalink
Change cookie hide button text examples
Browse files Browse the repository at this point in the history
Related to alphagov/govuk-design-system#2087

The original hide button text 'Hide this message' was raised in audits
as being unclear to users of assistive tech. This isn't hardcoded into
the component, but we do have examples which we should update with our
new recommended text: Hide cookie message.
  • Loading branch information
Vanita Barrett-Smith committed May 31, 2022
1 parent caa8918 commit a4cbe07
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 10 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ notes: >-
"role": "alert",
"actions": [
{
"text": "Hide this message",
"text": "Hide cookie message",
"type": "button",
"classes": "js-hide"
}
Expand All @@ -81,7 +81,7 @@ notes: >-
"role": "alert",
"actions": [
{
"text": "Hide this message",
"text": "Hide cookie message",
"type": "button",
"classes": "js-hide"
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ notes: >-
href: "#"
},
{
text: "Hide this message",
text: "Hide cookie message",
type: "submit",
name: "cookies",
value: "cookie-banner-dismissed",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ notes: >-
"role": "alert",
"actions": [
{
"text": "Hide this message",
"text": "Hide cookie message",
"href": currentUrl,
"type": "button",
"classes": "js-hide"
Expand Down
12 changes: 6 additions & 6 deletions src/govuk/components/cookie-banner/cookie-banner.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ examples:
- text: Your cookie preferences have been saved. You have accepted cookies.
role: alert
actions:
- text: Hide this message
- text: Hide cookie message
type: button

- name: rejected confirmation banner
Expand All @@ -119,7 +119,7 @@ examples:
- text: Your cookie preferences have been saved. You have rejected cookies.
role: alert
actions:
- text: Hide this message
- text: Hide cookie message
type: button

- name: client-side implementation
Expand All @@ -142,13 +142,13 @@ examples:
role: alert
hidden: true
actions:
- text: Hide this message
- text: Hide cookie message
type: button
- text: Your cookie preferences have been saved. You have rejected cookies.
role: alert
hidden: true
actions:
- text: Hide this message
- text: Hide cookie message
type: button

- name: with html
Expand Down Expand Up @@ -305,10 +305,10 @@ examples:
- text: Your cookie preferences have been saved. You have accepted cookies.
role: alert
actions:
- text: Hide this message
- text: Hide cookie message
type: button
- text: Your cookie preferences have been saved. You have rejected cookies.
role: alert
actions:
- text: Hide this message
- text: Hide cookie message
type: button

0 comments on commit a4cbe07

Please sign in to comment.