Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cookie Banner 'hide this message' button unclear when navigating out of context #2087

Closed
6 tasks done
vanitabarrett opened this issue Mar 2, 2022 · 1 comment · Fixed by #2207
Closed
6 tasks done

Cookie Banner 'hide this message' button unclear when navigating out of context #2087

vanitabarrett opened this issue Mar 2, 2022 · 1 comment · Fixed by #2207
Assignees
@vanitabarrett @calvin-lau-sig7 @dav-idc
Labels
accessibility 🐛 bug Something isn't working the way it should (including incorrect wording in documentation) cookie banner ⚠️ high priority Used by the team when triaging

Comments

@vanitabarrett
Copy link
Contributor

vanitabarrett commented Mar 2, 2022 •
edited
Loading

Description of the issue

Reported by users via Slack and the Design System backlog. This was flagged to them in an accessibility audit by DAC.

Steps to reproduce the issue

  1. Open the cookie banner confirmation message
  2. Tab to the button with a screenreader. The button is announced as 'Hide this message, button'.
  3. Can also be reproduced by navigating via form elements, e.g: in Mac Voiceover press VO+U and use the left and right arrows to navigate to the 'form elements' list. You should see 'Hide this message, button' listed.

Actual vs expected behaviour

The cookie banner 'hide this message button' doesn't have enough information when read out of context. It's not clear what the button relates to unless you already know you're inside the cookie banner.

The text is something which is passed into the component so can be changed by services themselves. Suggestion to change the examples in the design system (and in our own review-app in govuk-frontend) to something that makes sense out of context, for example: "hide cookie banner".

Who needs to work on this

Content Design; Developer

Done When

  • Agreed new content for the button
  • Updated examples in the design system
  • Updated the design system website cookie banner
  • Updated examples in the govuk-frontend review app
  • Updated any guidance in the design system (where necessary)
  • Draft comms for backlog and Slack/support queries
@vanitabarrett vanitabarrett added 🐛 bug Something isn't working the way it should (including incorrect wording in documentation) accessibility ⚠️ high priority Used by the team when triaging cookie banner labels Mar 2, 2022
@lfdebrux
Copy link
Member

We should update the community backlog when we start work on this, as we're being chased about it on Slack.

vanitabarrett pushed a commit to alphagov/govuk-frontend that referenced this issue May 31, 2022
Change cookie hide button text examples
a4cbe07 
Related to alphagov/govuk-design-system#2087

The original hide button text 'Hide this message' was raised in audits
as being unclear to users of assistive tech. This isn't hardcoded into
the component, but we do have examples which we should update with our
new recommended text: Hide cookie message.
@vanitabarrett vanitabarrett linked a pull request May 31, 2022 that will close this issue
Update cookie hide button to be more descriptive #2207
Merged
@vanitabarrett vanitabarrett mentioned this issue May 31, 2022
Merged
@vanitabarrett vanitabarrett mentioned this issue May 31, 2022
Open
querkmachine pushed a commit to alphagov/govuk-frontend that referenced this issue Oct 17, 2022
@querkmachine
Change cookie hide button text examples
f67e6f0 
Related to alphagov/govuk-design-system#2087

The original hide button text 'Hide this message' was raised in audits
as being unclear to users of assistive tech. This isn't hardcoded into
the component, but we do have examples which we should update with our
new recommended text: Hide cookie message.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vanitabarrett vanitabarrett

@calvin-lau-sig7 calvin-lau-sig7

@dav-idc dav-idc

Labels
accessibility 🐛 bug Something isn't working the way it should (including incorrect wording in documentation) cookie banner ⚠️ high priority Used by the team when triaging
Projects
GOV.UK Design System cycle board
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update cookie hide button to be more descriptive alphagov/govuk-design-system
5 participants
@lfdebrux @vanitabarrett @kellylee-gds @calvin-lau-sig7 @dav-idc